[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: FW: Final patch for audio recording with /dev/dsp
From:       Christopher Faylor <cgf-no-personal-reply-please () cygwin ! com>
Date:       2004-03-03 14:08:51
Message-ID: 20040303140851.GA13034 () redhat ! com
[Download RAW message or body]

On Wed, Mar 03, 2004 at 10:55:43AM +0100, Corinna Vinschen wrote:
>[Sorry for the delay, I didn't realize that my mail to cygwin-patches
> didn't come through]
>
>Hi Gerd,
>
>thanks for the patch, but regardless of the content, it's not acceptable
>for a few stylistic reasons:
>
>- All sentences end in a full stop in the ChangeLog.
>
>- Could you please change all one line if expressions like this:
>
>    if (head_ == depth1_) head_ = 0;
>
>  to
>
>    if (head_ == depth1_)
>      head_ = 0;
>
>- Please change `*(buffer+1)' to `*(buffer + 1)'.

Or better yet, in that case:  buffer[1]

cgf
[prev in list] [next in list] [prev in thread] [next in thread]