[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-apps
Subject:    Re: [PATCH cygport] pkg_info.cygpart: Do not detect dependencies on itself in ruby package
From:       Jon Turney via Cygwin-apps <cygwin-apps () cygwin ! com>
Date:       2024-05-06 14:12:08
Message-ID: 5e4c5b9f-4f11-4ab5-984e-108393b7acb4 () dronecode ! org ! uk
[Download RAW message or body]

On 03/04/2024 15:18, Daisuke Fujimura via Cygwin-apps wrote:
> Thank you for reviewing this.
> 
>> Can you clarify what the "failure" is here?
> 
[...]
> 
> /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file
> -- rbconfig (LoadError)
> 
[...]

Thanks very much for the detailed explanation.

So this is an error (or warning?) generated by invoking the 
not-yet-properly installed, just-built ruby in ${D}.

I applied your patch.

> On Sun, Mar 10, 2024 at 10:34 PM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>>
>> On 16/02/2024 12:51, Daisuke Fujimura via Cygwin-apps wrote:
>>> Attempting to create a package for ruby-3.3, but it fails when trying
>>> to detect a dependency on itself.
>>
>> Thanks for this patch.
>>
>> Can you clarify what the "failure" is here?
>>
>>> To avoid this, skip them if the target is `ruby`.
>>
>> The second hunk seems like a removes the dependency on ruby_xy for the
>> ruby package, which also provides ruby_xy.
>>
>> Historically, we've allowed self-dependencies like this, because they
>> seem to be benign, although it seems like we could do with some generic
>> code to suppress them

... except I added something to generically prevent a packages provides: 
appearing it it's requires:

[prev in list] [next in list] [prev in thread] [next in thread]