[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cups-commit
Subject:    [cups.commit] [CUPS] r10699 - trunk/cups
From:       cups-dev () easysw ! com
Date:       2012-11-15 18:20:30
Message-ID: 11471-cups.commit () news ! easysw ! com
[Download RAW message or body]

Author: mike
Date: 2012-11-15 10:20:29 -0800 (Thu, 15 Nov 2012)
New Revision: 10699
Log:
Add range checking to ippSetValueTag and ippSetGroupTag.


Modified:
   trunk/cups/ipp.c

Modified: trunk/cups/ipp.c
===================================================================
--- trunk/cups/ipp.c	2012-11-15 14:59:07 UTC (rev 10698)
+++ trunk/cups/ipp.c	2012-11-15 18:20:29 UTC (rev 10699)
@@ -3888,7 +3888,8 @@
   * Range check input - group tag must be 0x01 to 0x0F, per RFC 2911...
   */
 
-  if (!ipp || !attr || group_tag < IPP_TAG_ZERO || group_tag == IPP_TAG_END ||
+  if (!ipp || !attr || !*attr ||
+      group_tag < IPP_TAG_ZERO || group_tag == IPP_TAG_END ||
       group_tag >= IPP_TAG_UNSUPPORTED_VALUE)
     return (0);
 
@@ -4494,7 +4495,7 @@
   * Range check input...
   */
 
-  if (!ipp || !attr)
+  if (!ipp || !attr || !*attr)
     return (0);
 
  /*

_______________________________________________
cups-commit mailing list
cups-commit@easysw.com
http://lists.easysw.com/mailman/listinfo/cups-commit
[prev in list] [next in list] [prev in thread] [next in thread]