[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cups-bugs
Subject:    Re: [cups.bugs] [LOW] STR #3072: Too long device URI becomes
From:       Michael Sweet <msweet () apple ! com>
Date:       2009-01-23 22:01:38
Message-ID: 20090123220138.6D66A3C6847D () dns ! easysw ! com
[Download RAW message or body]

[STR Closed w/Resolution]

Fixed in Subversion repository.

Link: http://www.cups.org/str.php?L3072
Version: 1.4-current
Fix Version: 1.4-current (r8289)
["str3072.patch" (text/plain)]

Index: CHANGES.txt
===================================================================
--- CHANGES.txt	(revision 8287)
+++ CHANGES.txt	(working copy)
@@ -4,6 +4,8 @@
 CHANGES IN CUPS V1.4b3
 
 	- Documentation fixes (STR #3044, STR #3057)
+	- The web interface and scheduler did not support URIs up to 1024 bytes
+	  in length (STR #3072)
 	- Fixed pdftops issues with page sizes (STR #3063)
 	- Fixed pdftops issues with Ghostscript (STR #3062)
 	- The scheduler incorrectly registered default profiles for PostScript
Index: templates/choose-uri.tmpl
===================================================================
--- templates/choose-uri.tmpl	(revision 8287)
+++ templates/choose-uri.tmpl	(working copy)
@@ -10,7 +10,7 @@
 <TABLE>
 <TR>
 <TH CLASS="label">Connection:</TH>
-<TD><INPUT TYPE="TEXT" SIZE="60" MAXLENGTH="1024" NAME="DEVICE_URI" \
VALUE="{current_device_uri?{current_device_uri}:{device_uri}}"></TD> +<TD><INPUT \
TYPE="TEXT" SIZE="60" MAXLENGTH="1023" NAME="DEVICE_URI" \
VALUE="{current_device_uri?{current_device_uri}:{device_uri}}"></TD>  </TR>
 <TR>
 <TD></TD>
Index: templates/es/choose-uri.tmpl
===================================================================
--- templates/es/choose-uri.tmpl	(revision 8287)
+++ templates/es/choose-uri.tmpl	(working copy)
@@ -10,7 +10,7 @@
 <TABLE>
 <TR>
 <TH CLASS="label">Conexi&oacute;n:</TH>
-<TD><INPUT TYPE="TEXT" SIZE="60" MAXLENGTH="1024" NAME="DEVICE_URI" \
VALUE="{current_device_uri?{current_device_uri}:{device_uri}}"></TD> +<TD><INPUT \
TYPE="TEXT" SIZE="60" MAXLENGTH="1023" NAME="DEVICE_URI" \
VALUE="{current_device_uri?{current_device_uri}:{device_uri}}"></TD>  </TR>
 <TR>
 <TD></TD>
Index: scheduler/dirsvc.c
===================================================================
--- scheduler/dirsvc.c	(revision 8287)
+++ scheduler/dirsvc.c	(working copy)
@@ -283,7 +283,7 @@
 {
   cups_file_t		*fp;		/* remote.cache file */
   int			linenum;	/* Current line number */
-  char			line[1024],	/* Line from file */
+  char			line[4096],	/* Line from file */
 			*value,		/* Pointer to value */
 			*valueptr,	/* Pointer into value */
 			scheme[32],	/* Scheme portion of URI */
Index: scheduler/printers.c
===================================================================
--- scheduler/printers.c	(revision 8287)
+++ scheduler/printers.c	(working copy)
@@ -929,7 +929,7 @@
 {
   cups_file_t		*fp;		/* printers.conf file */
   int			linenum;	/* Current line number */
-  char			line[1024],	/* Line from file */
+  char			line[4096],	/* Line from file */
 			*value,		/* Pointer to value */
 			*valueptr;	/* Pointer into value */
   cupsd_printer_t	*p;		/* Current printer */
Index: scheduler/classes.c
===================================================================
--- scheduler/classes.c	(revision 8287)
+++ scheduler/classes.c	(working copy)
@@ -287,7 +287,7 @@
 {
   cups_file_t		*fp;		/* classes.conf file */
   int			linenum;	/* Current line number */
-  char			line[1024],	/* Line from file */
+  char			line[4096],	/* Line from file */
 			*value,		/* Pointer to value */
 			*valueptr;	/* Pointer into value */
   cupsd_printer_t	*p,		/* Current printer class */



_______________________________________________
cups-bugs mailing list
cups-bugs@easysw.com
http://lists.easysw.com/mailman/listinfo/cups-bugs


[prev in list] [next in list] [prev in thread] [next in thread]