[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils-bug
Subject:    bug#60489: Programs should exit after EIO from FICLONE or copy_file_range()
From:       Pádraig Brady <P () draigBrady ! com>
Date:       2023-01-06 14:47:43
Message-ID: cf472241-03f0-1247-f3b0-a03295e6e6a3 () draigBrady ! com
[Download RAW message or body]

On 02/01/2023 16:22, Pádraig Brady wrote:
> On 02/01/2023 13:28, Andreas Schwab wrote:
>> On Jan 02 2023, Pádraig Brady wrote:
>>
>>> +          /* Note error set is consistent with copy_file_range().  */
>>> +          bool no_clone_attempted = errno == ENOSYS || is_ENOTSUP (errno)
>>> +                                    || errno == EINVAL || errno == EBADF
>>> +                                    || errno == EXDEV || errno == ETXTBSY;
>>
>> Should this be refactored to avoid duplication?
> 
> Yes good call.
> We should also refactor the handling of clone failure
> to also apply to the usage of fclonefileat() on macOS.
> 
> Updated patch attached.

Pushed.

Marking this as done.

thanks,
Pádraig




[prev in list] [next in list] [prev in thread] [next in thread]