[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils-bug
Subject:    bug#14897: dd skip exit code
From:       Pádraig Brady <P () draigBrady ! com>
Date:       2013-07-18 22:14:44
Message-ID: 51E868D4.8060602 () draigBrady ! com
[Download RAW message or body]

On 07/18/2013 10:43 PM, Bernhard Voelker wrote:
> 
> On 07/18/2013 07:52 PM, Pádraig Brady wrote:
> 
>> * NEWS: Mention the change in behavior
> 
> s/$/./
> 
>> @@ -2010,7 +2013,9 @@ dd_copy (void)
>>  
>>        if (nread < 0)
>>          {
>> -          error (0, errno, _("error reading %s"), quote (input_file));
>> +          if (!(conversions_mask & C_NOERROR) || !(status_flags & STATUS_NONE))
>> +            error (0, errno, _("error reading %s"), quote (input_file));
>> +
>>            if (conversions_mask & C_NOERROR)
>>              {
>>                print_stats ();
> 
> This doesn't look like a non-fatal error to me.  Are you sure
> we really want to suppress this with status=none?

I wasn't sure about that one since POSIX says you _shall_ output
a diagnostic in that case.  But of course status=none is an extension,
so POSIX doesn't apply so.  Also with conv=noerror this is just a warning,
so for consistency it seems right to treat like all other warnings.

> Reading the Texinfo manual, I think this change in behavior should
> also be documented:
> 
>           Do not print any informational messages to stderr.  Error
>           messages are output as normal.
> 
> It probably should say something like "... any informational nor
> warning messages ...".

I will amend like that and push.

thanks for the review!
Pádraig.



[prev in list] [next in list] [prev in thread] [next in thread]