[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils-bug
Subject:    bug#12087: Wrong comment in passfd.c?
From:       Eric Blake <eblake () redhat ! com>
Date:       2012-07-30 12:24:21
Message-ID: 50167CF5.2090403 () redhat ! com
[Download RAW message or body]


tag 12087 fixed
thanks

[adding bug-gnulib, as the source of the bug]

On 07/29/2012 02:14 PM, Jann Horn wrote:
> Hello,
> it looks to me like this comment is wrong:
> 
> gnulib/lib/passfd.c:
> 101 /* recvfd receives a file descriptor through the socket.
> 102    The flags are a bitmask, possibly including O_CLOEXEC (defined in <fcntl.h>).
> 103 
> 104    Return 0 on success, or -1 with errno set in case of error.
> 105 */
> 106 int
> 107 recvfd (int sock, int flags)
> 
> It returns the fd, not 0, on success, right?

You are correct.  Thanks for the report; I've pushed a fix to gnulib.

Coreutils will pick it up on the next gnulib update; but as it is of
minor severity, I'm going to close this coreutils bug report now.  Feel
free to provide further comments!

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]