[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    Re: [PATCH 1/2] maint: exclude diff files from long lines check
From:       Bernhard Voelker <mail () bernhard-voelker ! de>
Date:       2015-02-11 7:03:53
Message-ID: 54DAFED9.6090806 () bernhard-voelker ! de
[Download RAW message or body]

On 02/11/2015 04:57 AM, Pádraig Brady wrote:
> * cfg.mk: Add .diff files to the exclusion expression
> for sc_long_lines, since the gnulib code might be >0= 80 chars.
> Note 80 char lines trigger due to the added +/- diff marks.

Interesting - the diff marks were already excluded, but you're right
with that also other lines in *.diff files may be longer.

FILTER_LONG_LINES =						\
  /^[^:]*\.diff:[^:]*:@@ / d;					\
  ...

Now as we're excluding the *.diff files entirely, I think we
should remove the above extra exclusion pattern.

> Also normalize the $$ used in the other sc_long_lines exclusion
> expressions.

Good catch: +1

Thanks & have a nice day,
Berny


[prev in list] [next in list] [prev in thread] [next in thread]