[prev in list] [next in list] [prev in thread] [next in thread]
List: coreutils
Subject: Re: [PATCH] maint: fix invalid patch in recent commit
From: <P () draigBrady ! com>
Date: 2015-02-03 10:48:59
Message-ID: 54D0A79B.8020502 () draigBrady ! com
[Download RAW message or body]
On 03/02/15 07:35, Bernhard Voelker wrote:
> On 02/03/2015 06:12 AM, Pádraig Brady wrote:
> Good idea, thanks.
> Minor issue: depending on the state of the gnulib directory,
> the syntax-check may ask questions and probably hang:
>
> ensure_gl_diffs_apply_cleanly
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> 8 out of 8 hunks ignored
> gl/lib/tempname.c.diff
> To refresh run: make refresh-gnulib-patches
> cfg.mk:127: recipe for target 'sc_ensure_gl_diffs_apply_cleanly' failed
> make: *** [sc_ensure_gl_diffs_apply_cleanly] Error 1
>
> OTOH, as this is the bad case anyway, having patch asking may not be
> much of a problem.
>
> Otherwise +1, thanks again.
I added a -f option to avoid prompts.
Also I redirected errors to stderr,
and with that I pushed.
Thanks for the review.
Pádraig.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic