[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    Re: [PATCH] maint: ensure "Co-authored-by" in commit message has an email address
From:       Pádraig Brady <P () draigBrady ! com>
Date:       2014-07-13 16:02:09
Message-ID: 53C2AD81.9060009 () draigBrady ! com
[Download RAW message or body]

On 07/13/2014 04:08 PM, Bernhard Voelker wrote:
> On 07/13/2014 04:43 PM, Pádraig Brady wrote:
>> Generally we try to keep emails out of commit messages since
>> they're quite ephemeral, and not subject to .mailmap etc.
> 
> Fair point.
> 
>> So I'm fine with committing this, but possibly better would
>> be to update gitlog-to-changelog to query git for the address?
>> Perhaps something like this would work (which also honors
>> the .mailmap):
>>
>>   git_email() {
>>     GIT_PAGER= git log -1 --author="$1" --pretty='format:%aE'
>>   }
>>   echo $(git_email "Niels Möller")
> 
> So this would only work if the co-author is the author of an
> older commit.  This seems to be okay, because otherwise, we'd
> add an entry in THANKS.in, right?

So there's the edge case where Co-authored-by could only
be in THANKS.in.  That would be most likely for a patch
submitted by a group of new contributors.
This has not happened yet for coreutils at least.

cheers,
Pádraig.


[prev in list] [next in list] [prev in thread] [next in thread]