[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    Re: [PATCH] basename: mention that the -s option implies -a in usage
From:       Bernhard Voelker <mail () bernhard-voelker ! de>
Date:       2014-03-26 10:37:58
Message-ID: 5332AE06.2040602 () bernhard-voelker ! de
[Download RAW message or body]

On 03/26/2014 11:09 AM, Pádraig Brady wrote:
> On 03/25/2014 10:41 PM, Bernhard Voelker wrote:
>> * src/basename.c (usage): Mention that -s implies -a.
>> (main): Add "fall through" comment to case 's'.
>>
>> Spotted by coverity: MISSING_BREAK.
______________^^^^^^^^


> Cool you must be running some static analysis.

sure, see above. ;-)

> I've just removed this from my own "misc fixes" branch.
>
> please push

done:
   http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=25c2f0d617

Thanks for the review.

Have a nice day,
Berny




[prev in list] [next in list] [prev in thread] [next in thread]