[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    Re: [PATCH 2/3] build: avoid compile warnings in factor.c on some systems
From:       Jim Meyering <jim () meyering ! net>
Date:       2012-10-23 12:41:23
Message-ID: 874nlltl70.fsf () rho ! meyering ! net
[Download RAW message or body]

P=E1draig Brady wrote:
> On 10/23/2012 01:13 PM, Jim Meyering wrote:
>> Thanks.
>> I confirmed that this addresses the problem.
>>
>> Did you consider other ways of addressing it,
>> say without adding that cast?  Imagine that
>> someone adds another addmod2 use in this code...
>> They will have to know to widen any argument that may
>> be narrower than uintmax_t.
>
> I agree it's not ideal,
> though I couldn't really come up with anything really clean,
> since it's a mixture of assembly and C.
>
> I'd already pushed before I saw this comment.

No problem.


[prev in list] [next in list] [prev in thread] [next in thread]