[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    Re: [PATCH] tests: correctly restrict factor test without GMP
From:       Jim Meyering <jim () meyering ! net>
Date:       2012-10-22 12:15:06
Message-ID: 87r4oqzos5.fsf () rho ! meyering ! net
[Download RAW message or body]

Pádraig Brady wrote:
> * tests/misc/factor.pl: Correct the precedence and
> regular expression in the command to check for GMP.
> ---
>  tests/misc/factor.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/misc/factor.pl b/tests/misc/factor.pl
> index 8f6edaa..540984f 100755
> --- a/tests/misc/factor.pl
> +++ b/tests/misc/factor.pl
> @@ -76,7 +76,7 @@ my @Tests =
>      );
>
>  # If we have GMP support, append tests to exercise it.
> -system "grep -w HAVE_GMP $ENV{CONFIG_HEADER} > /dev/null" == 0
> +(system "grep '^#define HAVE_GMP 1' $ENV{CONFIG_HEADER} > /dev/null") == 0
>    and push (@Tests,
>              ['bug-gmp-2_sup_128', '340282366920938463463374607431768211456',
>               {OUT => '2 'x127 . '2'}],

Both fixes look fine.
Thanks for cleaning up after me.


[prev in list] [next in list] [prev in thread] [next in thread]