[prev in list] [next in list] [prev in thread] [next in thread] 

List:       coreutils
Subject:    [PATCH] tests: inotify-rotate: avoid race condition with overloaded disk
From:       Jim Meyering <jim () meyering ! net>
Date:       2011-03-31 17:00:27
Message-ID: 87mxkbns2c.fsf () rho ! meyering ! net
[Download RAW message or body]

FYI,

>From 0ec711b5c4c5094fa206115a666e5878f463a07f Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 31 Mar 2011 18:56:47 +0200
Subject: [PATCH] tests: inotify-rotate: avoid race condition with overloaded
 disk

* tests/tail-2/inotify-rotate: Wait 50% longer for grep to succeed.
Without this change, this test would fail consistently when using
"make -j25 check" with F15 in a virtio- and spinning-rust-backed
virtual machine.
---
 tests/tail-2/inotify-rotate |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/tail-2/inotify-rotate b/tests/tail-2/inotify-rotate
index 3d02855..f9aa80f 100755
--- a/tests/tail-2/inotify-rotate
+++ b/tests/tail-2/inotify-rotate
@@ -24,12 +24,12 @@ fi
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 expensive_

-# Wait up to 10 seconds for grep REGEXP FILE to succeed.
+# Wait several seconds for grep REGEXP FILE to succeed.
 # Usage: grep_timeout REGEXP FILE
 grep_timeout()
 {
     local j
-    for j in $(seq 100); do
+    for j in $(seq 150); do
         grep $1 $2 > /dev/null && return 0
         sleep 0.1
     done
--
1.7.4.2.662.gcbd0


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic