[prev in list] [next in list] [prev in thread] [next in thread]
List: collectd-changes
Subject: [collectd-changes] collectd,
From: Florian Forster <octo () verplant ! org>
Date: 2008-12-30 16:30:36
Message-ID: E1LHhUK-0004lT-Qu () huhu ! verplant ! org
[Download RAW message or body]
src/network.c | 17 +++++++----------
src/types.db.pod | 16 +++++++++++++---
2 files changed, 20 insertions(+), 13 deletions(-)
New commits:
commit 66b7c4bce4e628d8c11cc6762621f155bd68536d
Merge: 602d70a9162bf2dc830142755836e82469230c5c 8eac3d8368d7687e8defbd7f8fa4b96217d6a5f8
Author: Florian Forster <octo@crystal.wlan.home.verplant.org>
Date: Tue Dec 30 17:24:06 2008 +0100
Merge branch 'collectd-4.4' into collectd-4.5
Conflicts:
src/network.c
commit 602d70a9162bf2dc830142755836e82469230c5c
Author: Florian Forster <octo@crystal.wlan.home.verplant.org>
Date: Tue Dec 30 14:44:39 2008 +0100
network plugin: Fix an invalid size of buffer being used.
When specifying the amount of data to copy, we used `sizeof (buffer)' where
`buffer' is a pointer, giving 4 or 8 bytes, depending on the architecture (and
not depending on the actual buffer size). This results in the `type' being sent
much more often than necessary and sometimes not sending a new type when is was
actually necessary. The only prominent case in the default configuration(s) was
`cpufreq' being used instead of `cpu', though.
While in the process, the global `type' buffer was replaced, because an
appropriate buffer is in `value_list_t' now.
Much thanks to Bruno Prémont for reporting and debugging this issue :)
References: #37
commit 8eac3d8368d7687e8defbd7f8fa4b96217d6a5f8
Author: Florian Forster <octo@crystal.wlan.home.verplant.org>
Date: Tue Dec 30 17:13:31 2008 +0100
network plugin: A fix for the buffer problem for version 4.4.
This patch fixes the same problem as 6605ff1a, the insufficient copying of
values to the `type' buffer.
Thanks again to Bruno Prémont for reporting and debugging this :)
Resolves: #37
commit 2745f0cf50319ea6645bc2c32be8cc0a03065038
Author: Florian Forster <octo@leeloo.lan.home.verplant.org>
Date: Sat Dec 20 13:34:43 2008 +0100
types.db(5): Fix a typo.
commit 49ebc1acf0525d8e328b5e01622f34e65a2cf437
Author: Florian Forster <octo@leeloo.lan.home.verplant.org>
Date: Sat Dec 20 11:20:31 2008 +0100
types.db(5): Explain in more detail how custom types should be added.
Apparently there was quite some confusion over this.
_______________________________________________
collectd-changes mailing list
collectd-changes@verplant.org
http://mailman.verplant.org/listinfo/collectd-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic