[prev in list] [next in list] [prev in thread] [next in thread] 

List:       collectd
Subject:    Re: [collectd] modbus plugin spamming console with debug info
From:       Eric Sandeen <sandeen () sandeen ! net>
Date:       2016-02-25 13:39:31
Message-ID: 56CF0413.5040207 () sandeen ! net
[Download RAW message or body]



On 2/25/16 4:49 AM, Marc Fournier wrote:
> 
> Hello Eric !
> 
> Eric Sandeen <sandeen@sandeen.net> writes:
> 
>> I hadn't noticed this before, but after running on a systemd system it
>> comes to the forefront:
>>
>>> Message from syslogd@sandeen at Feb 24 22:39:48 ...
>>>  collectd:<21><00><00><00><05><01><04><02><00><02>
>>
>>> Broadcast message from systemd-journald@sandeen.net (Wed 2016-02-24 22:39:48 CST):
>>
>>> collectd[22528]: <22><00><00><00><05><01><04><02><00><19>
>>
>> on every modbus communication.  ;)
>>
>> The plugin sets modbus_set_debug(ctx, 1); - that seems a bit odd to do unconditionally.
>>
>> Has anyone else run into this?  Setting to debug should almost certainly be optional,
>> AFAICT.
> 
> Thanks for pointing this out !
> 
> Here's a patch which should prevent this:
> https://github.com/collectd/collectd/pull/1561
> 
> Does it sound an acceptable solution ?

Yeah, makes sense to me; I don't know why systemd elevates this to a broadcast
message; didn't happen on my older distros.  But the solution looks good.  Sorry
for not just sending a patch.  :)

-Eric

_______________________________________________
collectd mailing list
collectd@verplant.org
http://mailman.verplant.org/listinfo/collectd
[prev in list] [next in list] [prev in thread] [next in thread]