[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cmake
Subject:    [CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"
From:       Yaron Cohen-Tal <yaronct () gmail ! com>
Date:       2016-07-30 15:04:54
Message-ID: CADKOXrAw+CQmhZ9vminsE7PVkvfYfPFpGMj0V_zacsTBg2g2Ew () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

In FindLibXml2.cmake, the name of the variable "LIBXML2_DEFINITIONS" is
confusing coz it describes actually what should be added to the
"COMPILE_FLAGS" property, not "COMPILE_DEFINITIONS". I think it should b
renamed to "LIBXML2_COMPILE_FLAGS". If u wish, I can submit a patch.

Thanx,
Yaron

[Attachment #5 (text/html)]

<div dir="ltr"><div><div><div>Hi,<br><br></div>In FindLibXml2.cmake, the name of the \
variable &quot;LIBXML2_DEFINITIONS&quot; is confusing coz it describes actually what \
should be added to the &quot;COMPILE_FLAGS&quot; property, not \
&quot;COMPILE_DEFINITIONS&quot;. I think it should b renamed to \
&quot;LIBXML2_COMPILE_FLAGS&quot;. If u wish, I can submit a \
patch.<br><br></div>Thanx,<br></div>Yaron<br></div>



-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: \
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information \
on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at \
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake



[prev in list] [next in list] [prev in thread] [next in thread]