[prev in list] [next in list] [prev in thread] [next in thread]
List: cmake
Subject: [CMake] CPack and PackageMaker
From: Harry Mallon <Harry () codexdigital ! com>
Date: 2016-05-23 14:05:03
Message-ID: 363C3873-ED8E-4B92-8A40-BE9EB19129BE () codexdigital ! com
[Download RAW message or body]
Thanks for your work on this,
I hope this can get into the main codebase soon. Currently we use internal \
productbuild and pkgbuild scripts from our pre-cmake days. Reading through your patch \
now I have some feedback:
1. Package ID:
The pkgid for pkgbuild can often be something other than \
"com.CPACK_PACKAGE_VENDOR.CPACK_PACKAGE_NAME.component->Name". It might be useful to \
introduce a new variable "CPACK_PRODUCTBUILD_<component>_PKGID" which could override \
the default behaviour if desired.
2. Pkgbuild Install Location:
From man:
"--install-location install-path
Specify the default install location for the contents of the package. For example, if \
you specify a single application component, you might specify an install-path of \
/Applications. pkgbuild attempts to infer a sensible install path if this option is \
not used, but it may not choose correctly. Note that whether or not the default \
install location is actually used by the OS X Installer depends on the distribution \
file you deploy with the package."
Is there any reason why you are not using the default behaviour? We have always used \
it previously and it would seem to be better than defining "/".
3. Pkgbuild Version:
"--version" in pkgbuild command line could be set to "CPACK_PACKAGE_VERSION" to allow \
normal version checking.
4. Productbuild Version:
"--version" in productbuild command line could be set to "CPACK_PACKAGE_VERSION" as \
well.
5. Finding programs:
"// TODO: find pkgbuild and productbuild" could be replaced with \
cmSystemTools::FindProgram for the two executables and return error messages if they \
are unavailable (which is unlikely).
Harry
Harry Mallon
CODEX | Software Engineer
60 Poland Street | London | England | W1F 7NT
E harry@codexdigital.com<mailto:harry@codexdigital.com> | T +44 203 7000 \
989<callto:+44%20203%207000%20989>
Website<www.codexdigital.com> | Facebook<https://www.facebook.com/codexdigital> | \
Twitter<http://twitter.com/codexdigital>
[http://www.codexdigital.com/?action=asset&id=E55D8A6F-AF62-4978-8FF1-435A85AFADBF]<http://www.codexdigital.com>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;" class=""> <div class="">Thanks for your work on this,</div>
<div class=""><br class="">
</div>
I hope this can get into the main codebase soon. Currently we use internal \
productbuild and pkgbuild scripts from our pre-cmake days. <div class="">Reading \
through your patch now I have some feedback:</div> <div class=""><br class="">
</div>
<div class="">1. Package ID:</div>
<div class="">The pkgid for pkgbuild can often be something other than \
"com.CPACK_PACKAGE_VENDOR.CPACK_PACKAGE_NAME.component->Name". It might \
be useful to introduce a new variable \
"CPACK_PRODUCTBUILD_<component>_PKGID" which could override the \
default behaviour if desired.</div>
<div class=""><br class="">
</div>
<div class="">2. Pkgbuild Install Location:</div>
<div class="">From man:</div>
<div class="">"<span class="" style="font-variant-ligatures: \
no-common-ligatures;"><b class="">--install-location</b> </span><span class="" \
style="text-decoration: underline; font-variant-ligatures: \
no-common-ligatures;">install-path</span></div> <div class="">
<div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;">Specify the default install \
location for the contents of the package. For example, if you specify \
a </span><span class="" style="font-variant-ligatures: \
no-common-ligatures;">single application component, you might specify \
an </span><span class="" style="text-decoration: underline; \
font-variant-ligatures: no-common-ligatures;">install-path</span><span class="" \
style="font-variant-ligatures: no-common-ligatures;"> of </span><span \
class="" style="text-decoration: underline; font-variant-ligatures: \
no-common-ligatures;">/Applications</span><span class="" \
style="font-variant-ligatures: no-common-ligatures;">. <b \
class="">pkgbuild</b> attempts </span>to infer a sensible install path if \
this option is not used, but it may not choose correctly. Note that whether or not \
the default install location is actually used by the OS X Installer depends on the \
distribution file you deploy with the package."</div> </div>
<div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;"><br class=""> </span></div>
<div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;">Is there any reason why you are \
not using the default behaviour? We have always used it previously and it would seem \
to be better than defining "/".</span></div>
<div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;"><br class=""> </span></div>
<div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;">3. Pkgbuild \
Version:</span></div> <div class="" style="margin: 0px; line-height: normal;"><span \
class="" style="font-variant-ligatures: no-common-ligatures;">"--version" \
in pkgbuild command line could be set to "</span>CPACK_PACKAGE_VERSION" to \
allow normal version checking.</div> <div class="" style="margin: 0px; line-height: \
normal;"><br class=""> </div>
<div class="" style="margin: 0px; line-height: normal;">4. Productbuild \
Version:</div> <div class="" style="margin: 0px; line-height: normal;"><span class="" \
style="font-variant-ligatures: no-common-ligatures;">"--version" in \
productbuild command line could be set to "</span>CPACK_PACKAGE_VERSION" as \
well.</div> <div class="" style="margin: 0px; line-height: normal;"><br class="">
</div>
<div class="" style="margin: 0px; line-height: normal;">5. Finding programs:</div>
<div class="" style="margin: 0px; line-height: normal;">"// TODO: find pkgbuild \
and productbuild" could be replaced with cmSystemTools::FindProgram for the two \
executables and return error messages if they are unavailable (which is \
unlikely).</div> <div class="" style="margin: 0px; line-height: normal;"><br \
class=""> </div>
<div class="" style="margin: 0px; line-height: normal;">Harry</div>
<p id="c1-id-6" style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; COLOR: #000; \
PADDING-BOTTOM: 0px; PADDING-TOP: 0px; PADDING-LEFT: 0px; MARGIN: 0px 0px 2px; \
LINE-HEIGHT: 12pt; PADDING-RIGHT: 0px"> Harry Mallon</p>
<p id="c1-id-7" style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; COLOR: #000; \
PADDING-BOTTOM: 0px; PADDING-TOP: 0px; PADDING-LEFT: 0px; MARGIN: 0px 0px 10px; \
LINE-HEIGHT: 12pt; PADDING-RIGHT: 0px"> CODEX | Software Engineer</p>
<p id="c1-id-8" style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; PADDING-BOTTOM: 0px; \
PADDING-TOP: 0px; PADDING-LEFT: 0px; MARGIN: 0px 0px 2px; LINE-HEIGHT: 12pt; \
PADDING-RIGHT: 0px"> <span id="c1-id-9" style="COLOR: gray">60 Poland Street</span> | \
<span id="c1-id-10" style="COLOR: gray"> London</span> | <span id="c1-id-11" \
style="COLOR: gray">England </span>| <span id="c1-id-12" style="COLOR: gray"> W1F 7NT \
</span></p> <p id="c1-id-14" style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; COLOR: gray; \
PADDING-BOTTOM: 0px; PADDING-TOP: 0px; PADDING-LEFT: 0px; MARGIN: 0px 0px 4px; \
LINE-HEIGHT: 12pt; PADDING-RIGHT: 0px"> E <a id="c1-id-15" style="TEXT-DECORATION: \
none; COLOR: gray" href="mailto:harry@codexdigital.com"> \
harry@codexdigital.com</a> <span id="c1-id-16" style="COLOR: #000">|</span> T <a \
id="c1-id-17" style="TEXT-DECORATION: none; COLOR: gray" href="callto:+44 203 \
7000 989"> +44 203 7000 989</a> </p>
<p style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; PADDING-BOTTOM: 0px; PADDING-TOP: 0px; \
PADDING-LEFT: 0px; MARGIN: 0px 0px 2px; LINE-HEIGHT: 12pt; PADDING-RIGHT: 0px"> <a \
title="Visit our website" style="TEXT-DECORATION: none; COLOR: gray" \
href="www.codexdigital.com">Website</a> | <a title="Find us on Facebook" \
style="TEXT-DECORATION: none; COLOR: gray" \
href="https://www.facebook.com/codexdigital"> Facebook</a> | <a title="Follow us on \
Twitter" style="TEXT-DECORATION: none; COLOR: gray" \
href="http://twitter.com/codexdigital"> Twitter</a></p>
<p id="c1-id-22" style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; MARGIN-TOP: 15px"><a \
id="c1-id-23" title="See us at IBC!" style="BORDER-TOP-STYLE: none; \
BORDER-BOTTOM-STYLE: none; BORDER-RIGHT-STYLE: none; OUTLINE-STYLE: none; \
BORDER-LEFT-STYLE: none" href="http://www.codexdigital.com"><img id="c1-id-24" \
style="BORDER-TOP-STYLE: none; BORDER-BOTTOM-STYLE: none; BORDER-RIGHT-STYLE: none; \
OUTLINE-STYLE: none; BORDER-LEFT-STYLE: none" alt="" \
src="http://www.codexdigital.com/?action=asset&id=E55D8A6F-AF62-4978-8FF1-435A85AFADBF"></a></p>
</body>
</html>
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at: \
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more information \
on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at \
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake
--===============1640188576==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic