[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cmake
Subject:    Re: [CMake] Latest UseJava.cmake
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2014-02-21 21:58:12
Message-ID: le8i57$ftf$1 () ger ! gmane ! org
[Download RAW message or body]

On 2014-02-21 13:48, Allen Byrne wrote:
> One is the issue with, http://public.kitware.com/Bug/view.php?id=14655, the
> CMAKE_JAVA_TARGET_OUTPUT_DIR doesn't override OUTPUT_DIR.

Pedantic: if OUTPUT_DIR is given, it should override 
CMAKE_JAVA_TARGET_OUTPUT_DIR. I think maybe you didn't mean to suggest 
otherwise, but the above can be read that way.

If OUTPUT_DIR is *not* given, CMAKE_JAVA_TARGET_OUTPUT_DIR should be 
used. IIUC this is what is not working for you? I wonder if this is an 
unexpected behavior in cmake_parse_arguments (setting it to empty if not 
specified rather than leaving it along)? I seem to recall there being a 
discussion about that semi-recently...

> I disagree with the
> issue being minor, because if you have a lot of JARs, it can be really
> annoying and error prone to set that everywhere. We just set the
> CMAKE_JAVA_TARGET_OUTPUT_DIR at the top of our root CMakeLists.cmake file.

As a work-around, you could write a wrapper function, but your 
disagreement is reasonable. Patches welcomed.

> Could MANIFEST be added to the options in:
> 
> cmake_parse_arguments(_add_jar
> ""
> "VERSION;OUTPUT_DIR;OUTPUT_NAME;ENTRY_POINT;MANIFEST"
> "SOURCES;INCLUDE_JARS"
> ${ARGN}
> )

Yes. (IIRC I only left it out because (a) it wasn't present previously, 
(b) I didn't need it myself and (c) I am lazy :-).) Again, patches welcomed.

-- 
Matthew

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: \
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more information \
on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at \
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[prev in list] [next in list] [prev in thread] [next in thread]