[prev in list] [next in list] [prev in thread] [next in thread]
List: cmake
Subject: Re: [CMake] Why is Ninja generator disabled by default?
From: Claus Klein <claus.klein () arcormail ! de>
Date: 2012-05-28 14:32:23
Message-ID: 574B451F-6353-498E-A1DF-A68FCAB60D28 () arcormail ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Please tack a lock at my builds too
All of this errors are NOT caused by ninja!
http://open.cdash.org/buildSummary.php?buildid=2315144
But with ninja I get the same result.
Some of the errors are caused by the fact that I use the current gcc47
compiler (build with macports), which does not understand the -arch
options used by this tests!
For the X11 error here is a patch which fix it (missing include)
The others, no idea, but this is a makefile project, not ninja!
With regards,
Claus
On 22.05.2012, at 13:02, David Cole wrote:
> Please take a look at the CMake dashboard:
>
> http://open.cdash.org/index.php?project=CMake
>
> I will allow the ninja generator to be enabled by default after
> interested parties fix all the failing tests in the "Nightly
> Expected" section related to the ninja generator submissions.
>
> Honestly, I was opposed to the ninja generator being merged to
> 'master' and enabled at all because of the failing tests on our
> dashboard. Luckily for all you ninja fans out there, I do not have
> dictator powers. ;-)
>
>
> David
>
>
> On Mon, May 21, 2012 at 4:27 PM, Andreas Mohr <andi@lisas.de> wrote:
> Hi,
>
> On Mon, May 21, 2012 at 10:40:03AM -0400, cmake-request@cmake.org
> wrote:
> > From: David Cole <david.cole@kitware.com>
> > I agree with Bill here -- we cannot turn it on by default until it
> works
> > sufficiently for typical use cases.
>
> So, what would be needed to turn CMake on by default?
> 'cause it does not "work sufficiently for typical use cases" :->
> </asbestos_suit>
>
>
> While there might be backwards compatibility reasons for only actually
> having Ninja truly enabled once it truly works (after all after some
> years
> certain user code may resort to merely checking whether the feature
> is provided or not, rather than doing sufficiently precise checks
> "well, in this CMake pre-beta it actually was still broken,
> and 3 days later they fixed it"),
> I cannot help but wonder whether this configuration (build-time
> disabling
> rather than a slightly special way of runtime disabling)
> is hindering progress a bit due to artificially limiting developer
> uptake.
> OTOH people who tend to like playing with certain bleeding edge
> things (like me)
> are actually able to enable it manually - it's just somewhat more
> effort:
>
> > For specialized use cases, if you know you want to turn it on, you
> can
> > easily re-build a CMake of your own that has it enabled. Simply
> turn on the
> > advanced cache option CMAKE_ENABLE_NINJA when configuring CMake.
>
>
> Andreas Mohr
>
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
[Attachment #5 (multipart/mixed)]
[Attachment #7 (text/html)]
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; ">Please tack a lock at my builds \
too<div><br></div><div>All of this errors are NOT caused by ninja!</div><div><a \
href="http://open.cdash.org/buildSummary.php?buildid=2315144">http://open.cdash.org/buildSummary.php?buildid=2315144</a></div><div><br></div><div>But \
with ninja I get the same result.</div><div><br></div><div>Some of the errors are \
caused by the fact that I use the current gcc47 compiler (build with macports), which \
does not understand the -arch options used by this \
tests!</div><div><br></div><div>For the X11 error here is a patch which fix it \
(missing include)</div><div><br></div><div>The others, no idea, but this is a \
makefile project, not ninja!</div><div><br></div><div>With \
regards,</div><div>Claus</div><div></div></body></html>
["TestsX11HelloWorldX11.patch" (TestsX11HelloWorldX11.patch)]
diff --git a/Tests/X11/HelloWorldX11.cxx b/Tests/X11/HelloWorldX11.cxx
index 5bbc19a..6cfecf9 100644
--- a/Tests/X11/HelloWorldX11.cxx
+++ b/Tests/X11/HelloWorldX11.cxx
@@ -21,6 +21,8 @@
#include <X11/Xutil.h>
#include <X11/Xos.h>
+#include <stdlib.h> // rand()
+
class Main {
public:
[Attachment #9 (text/html)]
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; "><div></div><div><br><div><div>On 22.05.2012, \
at 13:02, David Cole wrote:</div><br class="Apple-interchange-newline"><blockquote \
type="cite">Please take a look at the CMake dashboard:<div><br></div><div> <a \
href="http://open.cdash.org/index.php?project=CMake">http://open.cdash.org/index.php?project=CMake</a><br><br></div><div>I \
will allow the ninja generator to be enabled by default after interested parties fix \
all the failing tests in the "Nightly Expected" section related to the ninja \
generator submissions.</div> <div><br></div><div>Honestly, I was opposed to the ninja \
generator being merged to 'master' and enabled at all because of the failing tests on \
our dashboard. Luckily for all you ninja fans out there, I do not have dictator \
powers. ;-)</div> <div><br></div><div><br></div><div>David</div><div><br></div><div><br></div><div><div \
class="gmail_quote">On Mon, May 21, 2012 at 4:27 PM, Andreas Mohr <span \
dir="ltr"><<a href="mailto:andi@lisas.de" \
target="_blank">andi@lisas.de</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<br> <br> On Mon, May 21, 2012 at 10:40:03AM -0400, <a \
href="mailto:cmake-request@cmake.org">cmake-request@cmake.org</a> wrote:<br> > \
From: David Cole <<a \
href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>><br> <div \
class="im">> I agree with Bill here -- we cannot turn it on by default until it \
works<br> > sufficiently for typical use cases.<br> <br> </div>So, what would be \
needed to turn CMake on by default?<br> 'cause it does not "work sufficiently for \
typical use cases" :-><br> </asbestos_suit><br> <br> <br> While there might \
be backwards compatibility reasons for only actually<br> having Ninja truly enabled \
once it truly works (after all after some years<br> certain user code may resort to \
merely checking whether the feature<br> is provided or not, rather than doing \
sufficiently precise checks<br> "well, in this CMake pre-beta it actually was still \
broken,<br> and 3 days later they fixed it"),<br> I cannot help but wonder whether \
this configuration (build-time disabling<br> rather than a slightly special way of \
runtime disabling)<br> is hindering progress a bit due to artificially limiting \
developer uptake.<br> OTOH people who tend to like playing with certain bleeding edge \
things (like me)<br> are actually able to enable it manually - it's just somewhat \
more<br> effort:<br> <div class="HOEnZb"><div class="h5"><br> > For specialized \
use cases, if you know you want to turn it on, you can<br> > easily re-build a \
CMake of your own that has it enabled. Simply turn on the<br> > advanced cache \
option CMAKE_ENABLE_NINJA when configuring CMake.<br> <br> <br> </div></div><span \
class="HOEnZb"><font color="#888888">Andreas Mohr<br> \
</font></span></blockquote></div><br></div> --<br><br>Powered by <a \
href="http://www.kitware.com">www.kitware.com</a><br><br>Visit other Kitware \
open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br><br>Please \
keep messages on-topic and check the CMake FAQ at: <a \
href="http://www.cmake.org/Wiki/CMake_FAQ">http://www.cmake.org/Wiki/CMake_FAQ</a><br><br>Follow \
this link to subscribe/unsubscribe:<br><a \
href="http://www.cmake.org/mailman/listinfo/cmake">http://www.cmake.org/mailman/listinfo/cmake</a></blockquote></div><br></div></body></html>
--
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic