[prev in list] [next in list] [prev in thread] [next in thread]
List: clamav-users
Subject: Re: [clamav-users] =?iso-8859-1?q?PATCH=5B2=5D=3A_Re=3A_ClamAV=AE_bl?=
From: "Micah Snyder \(micasnyd\) via clamav-users" <clamav-users () lists ! clamav ! net>
Date: 2021-08-05 23:51:39
Message-ID: BYAPR11MB3174C0A53F27D59382ED22FCC6F29 () BYAPR11MB3174 ! namprd11 ! prod ! outlook ! com
[Download RAW message or body]
Hi Mark,
Unfortunately, I can't change CLAMAVUSER to CLAMAV_USER in the .in files in=
0.103 because it will break things with Autotools. I could change it to us=
e CLAMAVUSER as you suggest, and update the documentation. But that doesn't=
feel like a good solution either, since it will be different in 0.104.
So I'm inclined to leave these CMake issues in 0.103 on the grounds that CM=
ake was not ready or intended for production use in 0.103 and there are man=
y other issues with the CMake tooling in 0.103 that we can't easily backpor=
t.
But your fixes for 0.104 seem solid to me so I'll merge that PR now. Thank=
s again for your help!
-Micah
Micah Snyder
ClamAV Development
Talos
Cisco Systems, Inc.
________________________________
From: Mark Fortescue <mark.lists@thurning-instruments.co.uk>
Sent: Thursday, August 5, 2021 3:09 AM
To: Micah Snyder (micasnyd) <micasnyd@cisco.com>; ClamAV users ML <clamav-u=
sers@lists.clamav.net>
Subject: Re: PATCH[2]: Re: ClamAV=AE blog: ClamAV 0.104.0 Release Candidate=
is here!
Hi Micah,
Having picked up on one set of unset substitution variables I cheated
and used 'find'. 'grep'. 'sed'. 'cut' and 'sort -u' to go through and
find all the substitution variables and check that they were set :).
Please note that the CLAMAV_USER changes or setting CLAMAVUSER in the
documentation are also needed for 0.103.x.
Regards
Mark.
On 05/08/2021 03:07, Micah Snyder (micasnyd) wrote:
> Thanks for patch #2. Very good eye catching the CLAMAV_USER and CONFDIR
> variable issues.
> I've updated the PR with the change:
> https://github.com/Cisco-Talos/clamav/pull/231
> <https://github.com/Cisco-Talos/clamav/pull/231>
>
> CMake: Fix build on systems lacking inttypes format string macros by
> micahsnyder =B7 Pull Request #231 =B7 Cisco-Talos/clamav
> <https://github.com/Cisco-Talos/clamav/pull/231>
> Define _SF64_PREFIX and _SF32_PREFIX on systems that do not have these
> macros: PRIu64, PRIx64, PRIi64, PRIu32, PRIi32, PRIx32 This logic is the
> same as in the previous build system, here: https://g...
> github.com
>
> If you see any problems please let me know. Else, if all goes well with
> testing on my side I'll merge it.
>
>
> Micah Snyder
> ClamAV Development
> Talos
> Cisco Systems, Inc.
> ------------------------------------------------------------------------
> *From:* Mark Fortescue <mark.lists@thurning-instruments.co.uk>
> *Sent:* Friday, July 30, 2021 6:36 AM
> *To:* Micah Snyder (micasnyd) <micasnyd@cisco.com>; ClamAV users ML
> <clamav-users@lists.clamav.net>
> *Subject:* PATCH[2]: Re: ClamAV=AE blog: ClamAV 0.104.0 Release Candidate
> is here!
> Hi Micah,
>
> Please find attached patch #2 to clean up patch #1 'if' statements and
> fix some other issues fond (mostly documentation).
>
> The outstanding variable is LIBCLAMAV_LIBS.
>
> It is used by clamav-config.in and libclamav.pc.in.
>
> Not sure about the logic required for this one. On my OS, it is set to
> '-lbz2' for autotools but I don't know why it is being set and no other
> dependent libraries are there.
>
> I would expect it to be a list of all dependent libraries used when
> linking with libclamav.
>
> Regards
> Mark.
>
> On 29/07/2021 00:54, Micah Snyder (micasnyd) wrote:
>> How's this? https://github.com/Cisco-Talos/clamav/pull/231
>>
>
> <snipped>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} \
</style> </head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Hi Mark,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Unfortunately, I can't \
change CLAMAVUSER to CLAMAV_USER in the .in files in 0.103 because it will break \
things with Autotools. I could change it to use CLAMAVUSER as you suggest, and update \
the documentation. But that doesn't feel like a good solution either, since it will \
be different in 0.104. <br> </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> So I'm inclined to leave \
these CMake issues in 0.103 on the grounds that CMake was not ready or intended for \
production use in 0.103 and there are many other issues with the CMake tooling in \
0.103 that we can't easily backport. <br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);"> But your fixes for 0.104 seem solid to me so I'll merge that \
PR now. Thanks again for your help!</div> <div style="font-family: Calibri, \
Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);">
-Micah<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);"> <br>
</div>
<div id="Signature">
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);"> <br style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto"> <span \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto; display:inline!important">Micah Snyder</span><br \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto"> <span style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto; \
display:inline!important">ClamAV Development</span><br style="font-family:Helvetica; \
font-size:12px; font-weight:normal; orphans:auto; text-align:start; widows:auto"> \
<span style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto; display:inline!important">Talos</span><br \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto"> <span style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto; \
display:inline!important">Cisco Systems, Inc.</span><br> </div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" \
style="font-size:11pt" color="#000000"><b>From:</b> Mark Fortescue \
<mark.lists@thurning-instruments.co.uk><br> <b>Sent:</b> Thursday, August 5, \
2021 3:09 AM<br> <b>To:</b> Micah Snyder (micasnyd) <micasnyd@cisco.com>; \
ClamAV users ML <clamav-users@lists.clamav.net><br> <b>Subject:</b> Re: \
PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate is here!</font> \
<div> </div> </div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Micah,<br>
<br>
Having picked up on one set of unset substitution variables I cheated <br>
and used 'find'. 'grep'. 'sed'. 'cut' and 'sort -u' to go through and <br>
find all the substitution variables and check that they were set :).<br>
<br>
Please note that the CLAMAV_USER changes or setting CLAMAVUSER in the <br>
documentation are also needed for 0.103.x.<br>
<br>
Regards<br>
Mark.<br>
<br>
On 05/08/2021 03:07, Micah Snyder (micasnyd) wrote:<br>
> Thanks for patch #2. Very good eye catching the CLAMAV_USER and CONFDIR \
<br> > variable issues.<br>
> I've updated the PR with the change: <br>
> <a href="https://github.com/Cisco-Talos/clamav/pull/231">https://github.com/Cisco-Talos/clamav/pull/231</a><br>
> <<a href="https://github.com/Cisco-Talos/clamav/pull/231">https://github.com/Cisco-Talos/clamav/pull/231</a>><br>
> <br>
> CMake: Fix build on systems lacking inttypes format string macros by <br>
> micahsnyder · Pull Request #231 · Cisco-Talos/clamav <br>
> <<a href="https://github.com/Cisco-Talos/clamav/pull/231">https://github.com/Cisco-Talos/clamav/pull/231</a>><br>
> Define _SF64_PREFIX and _SF32_PREFIX on systems that do not have these <br>
> macros: PRIu64, PRIx64, PRIi64, PRIu32, PRIi32, PRIx32 This logic is the <br>
> same as in the previous build system, here: <a \
href="https://g">https://g</a>...<br> > github.com<br>
> <br>
> If you see any problems please let me know. Else, if all goes well with \
<br> > testing on my side I'll merge it.<br>
> <br>
> <br>
> Micah Snyder<br>
> ClamAV Development<br>
> Talos<br>
> Cisco Systems, Inc.<br>
> ------------------------------------------------------------------------<br>
> *From:* Mark Fortescue <mark.lists@thurning-instruments.co.uk><br>
> *Sent:* Friday, July 30, 2021 6:36 AM<br>
> *To:* Micah Snyder (micasnyd) <micasnyd@cisco.com>; ClamAV users ML <br>
> <clamav-users@lists.clamav.net><br>
> *Subject:* PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate <br>
> is here!<br>
> Hi Micah,<br>
> <br>
> Please find attached patch #2 to clean up patch #1 'if' statements and<br>
> fix some other issues fond (mostly documentation).<br>
> <br>
> The outstanding variable is LIBCLAMAV_LIBS.<br>
> <br>
> It is used by clamav-config.in and libclamav.pc.in.<br>
> <br>
> Not sure about the logic required for this one. On my OS, it is set to<br>
> '-lbz2' for autotools but I don't know why it is being set and no other<br>
> dependent libraries are there.<br>
> <br>
> I would expect it to be a list of all dependent libraries used when<br>
> linking with libclamav.<br>
> <br>
> Regards<br>
> Mark.<br>
> <br>
> On 29/07/2021 00:54, Micah Snyder (micasnyd) wrote:<br>
>> How's this? <a \
href="https://github.com/Cisco-Talos/clamav/pull/231">https://github.com/Cisco-Talos/clamav/pull/231</a><br>
>> <br>
> <br>
> <snipped><br>
> <br>
<br>
</div>
</span></font></div>
</body>
</html>
_______________________________________________
clamav-users mailing list
clamav-users@lists.clamav.net
https://lists.clamav.net/mailman/listinfo/clamav-users
Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq
http://www.clamav.net/contact.html#ml
--===============1728520746981417893==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic