[prev in list] [next in list] [prev in thread] [next in thread] 

List:       clamav-users
Subject:    Re: [clamav-users] Opinion wanted: Change default config directory usr/clamav
From:       "Micah Snyder \(micasnyd\) via clamav-users" <clamav-users () lists ! clamav ! net>
Date:       2021-08-05 2:20:55
Message-ID: BYAPR11MB3174864F470568C0A96037EAC6F09 () BYAPR11MB3174 ! namprd11 ! prod ! outlook ! com
[Download RAW message or body]

Hi all,

Thank you all for your input.

What I've gathered is that this change is overall not that important.  Even if it is \
perhaps a "better" design decision overall, it is probably too late now, and is \
                something those who really care can easily achieve by building with:
  -D APP_CONFIG_DIRECTORY=etc/clamav

Honestly, most people will probably end up using a distro build that is configured \
like this aanyways: https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build
 Unix from source (v0.104+) - ClamAV \
Documentation<https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build>
 Building ClamAV with CMake (v0.104 and newer) The following are instructions to \
build ClamAV version 0.104 and newer using CMake.. Tip: If you wish to build ClamAV \
version 0.103 or older from source, follow these instructions to build ClamAV using \
Autotools.. Building ClamAV with CMake (v0.104 and newer) Install prerequisites \
docs.clamav.net


I think I was right to put off merging this change to think about it and I'm glad I \
gathered input from the good people on this mailer.

Related: Some day in the future I'd like to see freshclam, and perhaps even clamd, \
work without requiring a configuration file. Moving the location of the config files \
now and then making them optional later will doubtless cause some confusion when \
someone puts the config in the wrong directory and sees it "working" but not using \
their changes.

So I'm going to go ahead and close the pull request and decline the original request \
after all.

Thanks again everyone for your feedback.

-Micah

Micah Snyder
ClamAV Development
Talos
Cisco Systems, Inc.
________________________________
From: clamav-users <clamav-users-bounces@lists.clamav.net> on behalf of G.W. Haywood \
                via clamav-users <clamav-users@lists.clamav.net>
Sent: Saturday, July 31, 2021 1:18 PM
To: Micah Snyder (micasnyd) via clamav-users <clamav-users@lists.clamav.net>
Cc: G.W. Haywood <clamav@jubileegroup.co.uk>
Subject: Re: [clamav-users] Opinion wanted: Change default config directory \
usr/clamav

Hi there,

On Sat, 31 Jul 2021, Micah Snyder (micasnyd) via clamav-users wrote:

> ... change the default directory for the config files from
> <prefix>/etc to <prefix>/etc/clamav. ...

This is relatively unimportant.

If it were up to me, I'd look to see if there's already what seems to
be an existing, sane, config directory and, if found, use it.  Perhaps
confirm it with the user building it first; you could even ask for it.
If not found, by all means create something in /usr/local/etc/opt/ or
whatever floats your FHS-compliant boat at the time.  But please try
not to mess things up for existing users who've had to put up with
quite enough of this kind of thing from package mantainers already.

> Unfortunately, I procrastinated it so hard I forgot to merge it
> before the first release candidate. ... I would like your opinion.

This is very important.  Think in terms of, say, trashing the database
for half a million customers.

I've already mentioned privately to Joel that I'm concerned about the
quality control over there.  This reinforces the feeling.  This is the
kind of thing which could de-orbit the ISS and cannot be excused.

Most people think quality control means testing.  It doesn't.

It's mostly about how you design, and document, and implement all your
procedures and processes so that things can *never* get forgotten, or
left out, or put in, by accident.  You need to get a very firm grip on
those things now, before you do more or less anything else.  It's the
manufacturing equivalent of growing up.

There must be somebody in the Cisco empire who deals with this stuff.
Find him, and spend some quality time with him[*].  It'll be worth it.

--

73,
Ged.
[*] The masculine embraces the feminine where the context permits.

_______________________________________________

clamav-users mailing list
clamav-users@lists.clamav.net
https://lists.clamav.net/mailman/listinfo/clamav-users


Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq

http://www.clamav.net/contact.html#ml


[Attachment #3 (text/html)]

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} \
</style> </head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Hi all,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Thank you all for your \
input. <br> </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> What I've gathered is \
that this change is overall not that important.&nbsp; Even if it is perhaps a \
&quot;better&quot; design decision overall, it is probably too late now, and is \
something those who really care can easily achieve by building with: <span \
style="font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> \
</span><br> <span style="font-size: 12pt; color: rgb(0, 0, 0); background-color: \
rgb(255, 255, 255);">&nbsp; -D <span class="blob-code-inner blob-code-marker"><span \
class="pl-c1">APP_CONFIG_DIRECTORY</span></span>=etc</span>/clamav<br> </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Honestly, most people \
will probably end up using a distro build that is configured like this aanyways: <a \
href="https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build" \
id="LPlnk"> https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build</a><br>
 </div>
<div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview _EReadonly_1">
<div id="LPBorder_GTaHR0cHM6Ly9kb2NzLmNsYW1hdi5uZXQvbWFudWFsL0luc3RhbGxpbmcvSW5zdGFsbGluZy1mcm9tLXNvdXJjZS1Vbml4Lmh0bWwjYS1saW51eC1kaXN0cmlidXRpb24tc3R5bGUtYnVpbGQ." \
class="LPBorder246342" style="width: 100%; margin-top: 16px; margin-bottom: 16px; \
position: relative; max-width: 800px; min-width: 424px;"> <table \
id="LPContainer246342" role="presentation" style="padding: 12px 36px 12px 12px; \
width: 100%; border-width: 1px; border-style: solid; border-color: rgb(200, 200, \
200); border-radius: 2px;"> <tbody>
<tr style="border-spacing: 0px;" valign="top">
<td style="width: 100%;">
<div id="LPTitle246342" style="font-size: 21px; font-weight: 300; margin-right: 8px; \
font-family: &quot;wf_segoe-ui_light&quot;, &quot;Segoe UI Light&quot;, &quot;Segoe \
WP Light&quot;, &quot;Segoe UI&quot;, &quot;Segoe WP&quot;, Tahoma, Arial, \
sans-serif; margin-bottom: 12px;"> <a target="_blank" id="LPUrlAnchor246342" \
href="https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build" \
style="text-decoration: none; color:var(--themePrimary);">Unix from source (v0.104+) \
- ClamAV Documentation</a></div> <div id="LPDescription246342" style="font-size: \
14px; max-height: 100px; color: rgb(102, 102, 102); font-family: \
&quot;wf_segoe-ui_normal&quot;, &quot;Segoe UI&quot;, &quot;Segoe WP&quot;, Tahoma, \
Arial, sans-serif; margin-bottom: 12px; margin-right: 8px; overflow: hidden;"> \
Building ClamAV with CMake (v0.104 and newer) The following are instructions to build \
ClamAV version 0.104 and newer using CMake.. Tip: If you wish to build ClamAV version \
0.103 or older from source, follow these instructions to build ClamAV using \
Autotools..  Building ClamAV with CMake (v0.104 and newer) Install \
prerequisites</div> <div id="LPMetadata246342" style="font-size: 14px; font-weight: \
400; color: rgb(166, 166, 166); font-family: &quot;wf_segoe-ui_normal&quot;, \
&quot;Segoe UI&quot;, &quot;Segoe WP&quot;, Tahoma, Arial, sans-serif;"> \
docs.clamav.net</div> </td>
</tr>
</tbody>
</table>
</div>
</div>
<br>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> I think I was right to \
put off merging this change to think about it and I'm glad I gathered input from the \
good people on this mailer. <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
                color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Related: Some day in the future I'd like to see freshclam, and perhaps even clamd, \
work without requiring a configuration file. Moving the location of the config files \
now and then making them optional later will doubtless cause some confusion when \
someone  puts the config in the wrong directory and sees it &quot;working&quot; but \
not using their changes. <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> So I'm going to go ahead \
and close the pull request and decline the original request after all.<br> </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Thanks again everyone \
for your feedback. &nbsp;<br> </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
                color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
-Micah<br>
</div>
<div>
<div id="Signature">
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; \
color: rgb(0, 0, 0);"> <br style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto"> <span \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto; display:inline!important">Micah Snyder</span><br \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto"> <span style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto; \
display:inline!important">ClamAV Development</span><br style="font-family:Helvetica; \
font-size:12px; font-weight:normal; orphans:auto; text-align:start; widows:auto"> \
<span style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto; display:inline!important">Talos</span><br \
style="font-family:Helvetica; font-size:12px; font-weight:normal; orphans:auto; \
text-align:start; widows:auto"> <span style="font-family:Helvetica; font-size:12px; \
font-weight:normal; orphans:auto; text-align:start; widows:auto; \
display:inline!important">Cisco Systems, Inc.</span><br> </div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size: 11pt;" face="Calibri, \
sans-serif" color="#000000"><b>From:</b> clamav-users \
&lt;clamav-users-bounces@lists.clamav.net&gt; on behalf of G.W. Haywood via \
clamav-users &lt;clamav-users@lists.clamav.net&gt;<br> <b>Sent:</b> Saturday, July \
31, 2021 1:18 PM<br> <b>To:</b> Micah Snyder (micasnyd) via clamav-users \
&lt;clamav-users@lists.clamav.net&gt;<br> <b>Cc:</b> G.W. Haywood \
&lt;clamav@jubileegroup.co.uk&gt;<br> <b>Subject:</b> Re: [clamav-users] Opinion \
wanted: Change default config directory usr/clamav</font> <div>&nbsp;</div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Hi there,<br>
<br>
On Sat, 31 Jul 2021, Micah Snyder (micasnyd) via clamav-users wrote:<br>
<br>
&gt; ... change the default directory for the config files from<br>
&gt; &lt;prefix&gt;/etc to &lt;prefix&gt;/etc/clamav. ...<br>
<br>
This is relatively unimportant.<br>
<br>
If it were up to me, I'd look to see if there's already what seems to<br>
be an existing, sane, config directory and, if found, use it.&nbsp; Perhaps<br>
confirm it with the user building it first; you could even ask for it.<br>
If not found, by all means create something in /usr/local/etc/opt/ or<br>
whatever floats your FHS-compliant boat at the time.&nbsp; But please try<br>
not to mess things up for existing users who've had to put up with<br>
quite enough of this kind of thing from package mantainers already.<br>
<br>
&gt; Unfortunately, I procrastinated it so hard I forgot to merge it<br>
&gt; before the first release candidate. ... I would like your opinion.<br>
<br>
This is very important.&nbsp; Think in terms of, say, trashing the database<br>
for half a million customers.<br>
<br>
I've already mentioned privately to Joel that I'm concerned about the<br>
quality control over there.&nbsp; This reinforces the feeling.&nbsp; This is the<br>
kind of thing which could de-orbit the ISS and cannot be excused.<br>
<br>
Most people think quality control means testing.&nbsp; It doesn't.<br>
<br>
It's mostly about how you design, and document, and implement all your<br>
procedures and processes so that things can *never* get forgotten, or<br>
left out, or put in, by accident.&nbsp; You need to get a very firm grip on<br>
those things now, before you do more or less anything else.&nbsp; It's the<br>
manufacturing equivalent of growing up.<br>
<br>
There must be somebody in the Cisco empire who deals with this stuff.<br>
Find him, and spend some quality time with him[*].&nbsp; It'll be worth it.<br>
<br>
-- <br>
<br>
73,<br>
Ged.<br>
[*] The masculine embraces the feminine where the context permits.<br>
<br>
_______________________________________________<br>
<br>
clamav-users mailing list<br>
clamav-users@lists.clamav.net<br>
<a href="https://lists.clamav.net/mailman/listinfo/clamav-users">https://lists.clamav.net/mailman/listinfo/clamav-users</a><br>
 <br>
<br>
Help us build a comprehensive ClamAV guide:<br>
<a href="https://github.com/vrtadmin/clamav-faq">https://github.com/vrtadmin/clamav-faq</a><br>
 <br>
<a href="http://www.clamav.net/contact.html#ml">http://www.clamav.net/contact.html#ml</a><br>
 </div>
</span></font></div>
</body>
</html>



_______________________________________________

clamav-users mailing list
clamav-users@lists.clamav.net
https://lists.clamav.net/mailman/listinfo/clamav-users


Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq

http://www.clamav.net/contact.html#ml

--===============5601418704365313865==--

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic