[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    [PATCH v6 3/7] cgit.js: line range highlight: make responsive to url changes
From:       Andy Green <andy () warmcat ! com>
Date:       2018-06-29 1:40:29
Message-ID: 153023642954.27756.5062415435944544498.stgit () mail ! warmcat ! com
[Download RAW message or body]

Browser default interpretation of the # part of the URL is
to try to match it to an element ID one time at page load.

Subsequent modifications in the URL bar are ignored, even if
you hit enter there.

This patch makes the line range highlight able to clean up
after itself and be reapplied, and has the highlight function
listen for hashchange events and re-interpret the # part
when they occur.

Now if you edit the URL and press enter, any existing highlight
is removed, the # part reinterpreted and the new highlight
applied automatically.

This is particularly useful if you edit the # link with the
intention to show a range before copying the URL.

Clicking on the line number, which changes the URL bar to
have a corresponding #n part, also triggers hashchange and
makes the clicked line be highlit immediately.

Signed-off-by: Andy Green <andy@warmcat.com>
---
 cgit.js |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/cgit.js b/cgit.js
index 7c034e3..6cc27c1 100644
--- a/cgit.js
+++ b/cgit.js
@@ -33,6 +33,18 @@ function line_range_highlight()
 {
 	var h = window.location.hash, l1 = 0, l2 = 0, e, t;
 
+	e = document.getElementById("cgit-line-range");
+	if (e) {
+		l1 = e.l1;
+		while (l1 <= e.l2) {
+			var e1;
+			e1 = document.getElementById('n' + l1++);
+			e1.style.backgroundColor = null;
+		}
+
+		e.remove();
+	}
+
 	l1 = parseInt(h.substring(2));
 	if (!l1)
 		return;
@@ -56,6 +68,7 @@ function line_range_highlight()
 	de.className = "selected-lines";
 	de.style.bottom = e.style.bottom;
 	de.style.top = collect_offsetTop(e) + 'px';
+	de.id = "cgit-line-range";
 	de.l1 = l1;
 	de.l2 = l2;
 
@@ -89,4 +102,8 @@ window.addEventListener("load", function() {
 	line_range_highlight();
 }, false);
 
+window.addEventListener("hashchange", function() {
+	line_range_highlight();
+}, false);
+
 })();

_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
[prev in list] [next in list] [prev in thread] [next in thread]