[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    Re: [PATCH 3/5] ui-shared: make a char* parameter const
From:       John Keeping <john () keeping ! me ! uk>
Date:       2017-09-30 12:00:17
Message-ID: 20170930120017.GC2327 () john ! keeping ! me ! uk
[Download RAW message or body]

On Wed, Sep 27, 2017 at 05:43:29PM -0500, Jeff Smith wrote:
> All cgit_xxx_link functions take const char* for the 'name' parameter,
> except for cgit_commit_link, which takes a char* and subsequently
> modifies the contents.  Avoiding the content changes, and making it
> const char* will avoid the need to make copies of const char* strings
> being passed to cgit_commit_link.
> 
> Signed-off-by: Jeff Smith <whydoubt@gmail.com>

Reviewed-by: John Keeping <john@keeping.me.uk>

> ---
>  ui-shared.c | 19 ++++++++-----------
>  ui-shared.h |  2 +-
>  2 files changed, 9 insertions(+), 12 deletions(-)
_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit
[prev in list] [next in list] [prev in thread] [next in thread]