[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    Re: [PATCH 1/1] git: update to v2.12.0
From:       Christian Hesse <list () eworm ! de>
Date:       2017-06-06 14:12:16
Message-ID: 20170606161216.1a860d01 () leda
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


John Keeping <john@keeping.me.uk> on Sat, 2017/03/04 12:22:
> On Wed, Mar 01, 2017 at 11:57:55AM +0100, Christian Hesse wrote:
> > From: Christian Hesse <mail@eworm.de>
> > 
> > Update to git version v2.12.0: With commit 8aee769f (pathspec: copy and
> > free owned memory) member 'match' of 'struct pathspec_item' is no longer
> > 'const char*' but just 'char*'.
>
> This feels a bit invasive for a change that just affects pathspec_item.
> Can't we keep most of CGit's API the same (and keep prefixes "const")
> and just adjust at the lowest level?
> 
> Maybe something like this instead?

Sorry for the late answer...

Probably makes sense. I have an alternative branch that looks similar to
your patch. ;)

As you sent this first... Want to rebase for git v2.13.1?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}

[Attachment #5 (application/pgp-signature)]

_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit


[prev in list] [next in list] [prev in thread] [next in thread]