[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    Re: [PATCH 3/5] Revert "ui-shared: add rel-vcs microformat links to HTML header"
From:       Juuso Lapinlampi <wub () partyvan ! eu>
Date:       2016-05-11 20:28:00
Message-ID: 20160511202800.GA23230 () partyvan ! eu
[Download RAW message or body]

On Wed, May 11, 2016 at 07:45:34PM +0100, John Keeping wrote:
> On Wed, May 11, 2016 at 06:04:16PM +0000, Juuso Lapinlampi wrote:
> > See: a24995bf8c55114044d6baf32ad5e8c3a04d924d
> 
> You can't do this, the commit hash will be different when the patch is
> applied from an email.

Oops. Sometimes I forget git-send-email(1) doesn't equal to
git-format-patch(1) patch files, which I often share on IRC with
different projects.

See: https://notabug.org/WubTheCaptain/cgit/commit/b0f9e4edbd6ec2682332b77b1c4e52a1e7d5b12c.
The branch is wub/modernize-html.

This is also one big reason why merges matter and are preferred over
squashed commits, as you claimed privately Jason to not normally merge
via branches (which I consider bad practice).
_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
[prev in list] [next in list] [prev in thread] [next in thread]