[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    Re: [PATCH] ui-commit: display commit notes as 'raw'
From:       Stefan Naewe <stefan.naewe () gmail ! com>
Date:       2015-03-21 15:37:39
Message-ID: CAJzBP5RcgJ-=Z3zoDDVENBWgR9t-+QS9d8ZNsRnqotE7k0+Gtw () mail ! gmail ! com
[Download RAW message or body]

On Sat, Mar 21, 2015 at 2:19 PM, John Keeping <john@keeping.me.uk> wrote:
> On Sat, Mar 21, 2015 at 02:11:51PM +0100, Stefan Naewe wrote:
>> On Fri, Mar 20, 2015 at 10:29 PM, John Keeping <john@keeping.me.uk> wrote:
>> > On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
>> >> When the git function format_display_notes() is called
>> >> with a value != 0 as the last argument ('raw') the notes text
>> >> gets displayed w/o an additional 'Notes:' header. This seems
>> >> to be better suited for our needs since we're already displaying
>> >> a similar header.
>> >
>> > What happens when there are multiple display notes refs?  It seems that
>> > without "raw", format_note() puts the name of the ref in the header it
>> > prints (if it's not the default notes ref).
>> That's true for 'git show --notes=...' for example.
>>
>> But how would you specify the name of the notes ref in cgit ?
>
> git config --add notes.displayRef ...

Thanks. That looks like attached. One without and one with my patch.

Maybe we should drop the "Notes" headline that cgit generates, instead ?

Stefan
-- 
----------------------------------------------------------------
python -c "print '73746566616e2e6e6165776540676d61696c2e636f6d'.decode('hex')"

["shot-cgit-notes-2refs.png" (image/png)]
["shot-cgit-notes-2refs-raw.png" (image/png)]

_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit


[prev in list] [next in list] [prev in thread] [next in thread]