[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cgit
Subject:    [PATCH] t0109: chain operations with &&
From:       john () keeping ! me ! uk (John Keeping)
Date:       2013-04-10 22:40:48
Message-ID: 20130410224048.GL2222 () serenity ! lan
[Download RAW message or body]

On Wed, Apr 10, 2013 at 02:16:44PM +0200, Jason A. Donenfeld wrote:
> On Wed, Apr 10, 2013 at 2:11 PM, John Keeping <john at keeping.me.uk> wrote:
> > Without '&&' between operations, we will not detect if strace or cgit
> > exit with an error status, which would cause a false positive test
> > status in this case.
> 
> I wonder if for some of the larger && chains in other tests "set -e"
> would be a bit cleaner. I don't know if setting that inside the test
> string will bubble the setting back up to the test harness (which
> would be bad) or if it would be local for the test (which would be
> ideal). Something to investigate.

I expect if it was that easy, the tests in Git would take an approach
more like that.  Personally, I have found in the past that using
"set -e" often leads to problems later on, so I would prefer to keep the
&&-chain.



[prev in list] [next in list] [prev in thread] [next in thread]