[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-dev
Subject:    Re: [cfe-dev] [PATCH] Clang Static Analyzer support for temporary destructors
From:       Jordan Rose <jordan_rose () apple ! com>
Date:       2014-03-31 22:47:16
Message-ID: 1530AFE9-31FB-4C3B-9D12-29FFA5B1B52B () apple ! com
[Download RAW message or body]


On Mar 31, 2014, at 10:40, Alex McCarthy <alexmc@google.com> wrote:

> Thanks for your advice, Jordan.
> 
> I've split the NORETURN printing changes to CFG.cpp and the new test additions into \
> a separate patch (attached). Hopefully this should be a safe no-op from a behavior \
> perspective: debug output changes slightly, and the new test cases more accurately \
> reflects current clang behavior. Does this look safe to commit?

Rather than commenting out tests, I'd prefer you put them in with the "wrong" \
expected-warnings, and then put a FIXME next to the warnings. Commented-out tests \
become dead tests all too easily.

I would drop the tests from nullptr.cpp. That file's for testing nullptr and \
nullptr_t specifically, not null pointers in general, and the new tests don't \
actually test any new behavior if we already believe that nullptr properly converts \
to a null pointer value.

Jordan

_______________________________________________
cfe-dev mailing list
cfe-dev@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


[prev in list] [next in list] [prev in thread] [next in thread]