[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-dev
Subject:    Re: [cfe-dev] disabled Sema/ms-inline-asm.c test
From:       Bob Wilson <bob.wilson () apple ! com>
Date:       2013-11-29 22:39:22
Message-ID: 60F94C14-FA94-43CE-AA8A-04B5013D444C () apple ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Nov 21, 2013, at 3:22 PM, Alp Toker <alp@nuanti.com> wrote:

> 
> On 21/11/2013 18:37, Alp Toker wrote:
> > It's possible a commit I made fixed this (r193685) or if not, a similar fix might \
> > solve the problem.  
> > I'm in favour of switching the test back on on and collecting data on what the \
> > crash is, or indeed if it's still broken at all. 
> 
> So, I looked into Sema/ms-inline-asm.c. There's good news and there's bad news..
> 
> The good news: r193685 probably did fix the original crash that would have happened \
> on Hexagon or wherever the necessary parser wasn't enabled in the build \
> configuration. This was indeed a clang problem. 
> The bad news: In the period this test was disabled, the feature appears to have \
> regressed and it now crashes on all platforms: 
> mov eax, 1+++ // expected-error 2 {{unknown token in expression}}
> 
> Assertion failed: (OperandStack.size() > 1 && "Too few operands."), function \
> execute, file llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp, line 150. 
> Unfortunately an ASM parser test equivalent to the clang one never existed in \
> LLVM's own suite. 
> CC'ing in llvmdev. Does X86AsmParser.cpp have an active maintainer?
> 
> Alp.

I’ve filed this as PR18096.

> 
> 
> > 
> > 
> > The log disabling the test in question was: 
> > 
> > Author: Chad Rosier <mcrosier@apple.com> 
> > Date:   Thu Jan 24 20:33:35 2013 +0000 
> > 
> > Temporarily XFAIL this test; the compiler will segfault if the target-specific 
> > parser is not included in the compiler. Thanks to Renato for discovering the 
> > underlying issue. 
> > 
> > 
> > On 21/11/2013 17:36, Bob Wilson wrote: 
> > > Hi Chad, 
> > > 
> > > Back in January, you “temporarily” disabled the Sema/ms-inline-asm.c test.  See \
> > > clang svn r173365 and r173367.  That test is still disabled.  Did you have a \
> > > plan for getting it reenabled?  
> > > —Bob 
> > > _______________________________________________ 
> > > cfe-dev mailing list 
> > > cfe-dev@cs.uiuc.edu 
> > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev 
> > 
> 
> -- 
> http://www.nuanti.com
> the browser experts


[Attachment #5 (text/html)]

<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;"><br><div><div>On Nov 21, 2013, at 3:22 \
PM, Alp Toker &lt;<a href="mailto:alp@nuanti.com">alp@nuanti.com</a>&gt; \
wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">  
    <meta content="text/html; charset=windows-1252" http-equiv="Content-Type">
  
  <div bgcolor="#FFFFFF" text="#000000">
    <br>
    <div class="moz-cite-prefix">On 21/11/2013 18:37, Alp Toker wrote:<br>
    </div>
    <blockquote cite="mid:528E52CD.7040900@nuanti.com" type="cite">It's
      possible a commit I made fixed this (r193685) or if not, a similar
      fix might solve the problem.
      <br>
      <br>
      I'm in favour of switching the test back on on and collecting data
      on what the crash is, or indeed if it's still broken at all.
      <br>
    </blockquote>
    <br>
    So, I looked into Sema/ms-inline-asm.c. There's good news and
    there's bad news..<br>
    <br>
    The good news: r193685 probably did fix the original crash that
    would have happened on Hexagon or wherever the necessary parser
    wasn't enabled in the build configuration. This was indeed a clang
    problem.<br>
    <br>
    The bad news: In the period this test was disabled, the feature
    appears to have regressed and it now crashes on all platforms:<br>
    <br>
    <code>mov eax, 1+++ // expected-error 2 {{unknown token in
      expression}}</code><code><br>
    </code>&nbsp; <br>
    <code>Assertion failed: (OperandStack.size() &gt; 1 &amp;&amp; "Too
      few operands."), function execute, file
      llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp, line 150.</code><br>
    <br>
    Unfortunately an ASM parser test equivalent to the clang one never
    existed in LLVM's own suite.<br>
    <br>
    CC'ing in llvmdev. Does X86AsmParser.cpp have an active \
maintainer?</div></blockquote><blockquote type="cite"><div bgcolor="#FFFFFF" \
text="#000000">  <br>
    Alp.<br></div></blockquote><div><br></div>I’ve filed this as \
PR18096.</div><div><br><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000"> \
<br>  <br>
    <blockquote cite="mid:528E52CD.7040900@nuanti.com" type="cite">
      <br>
      <br>
      The log disabling the test in question was:
      <br>
      <br>
      Author: Chad Rosier <a class="moz-txt-link-rfc2396E" \
href="mailto:mcrosier@apple.com">&lt;mcrosier@apple.com&gt;</a>  <br>
      Date:&nbsp;&nbsp; Thu Jan 24 20:33:35 2013 +0000
      <br>
      <br>
      &nbsp;&nbsp;&nbsp; Temporarily XFAIL this test; the compiler will segfault if \
the  target-specific
      <br>
      &nbsp;&nbsp;&nbsp; parser is not included in the compiler. Thanks to Renato for
      discovering the
      <br>
      &nbsp;&nbsp;&nbsp; underlying issue.
      <br>
      <br>
      <br>
      On 21/11/2013 17:36, Bob Wilson wrote:
      <br>
      <blockquote type="cite">Hi Chad,
        <br>
        <br>
        Back in January, you “temporarily” disabled the
        Sema/ms-inline-asm.c test.&nbsp; See clang svn r173365 and r173367.&nbsp;
        That test is still disabled.&nbsp; Did you have a plan for getting it
        reenabled?
        <br>
        <br>
        —Bob
        <br>
        _______________________________________________
        <br>
        cfe-dev mailing list
        <br>
        <a class="moz-txt-link-abbreviated" \
href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a>  <br>
        <a class="moz-txt-link-freetext" \
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a>
  <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
    <pre class="moz-signature" cols="72">-- 
<a class="moz-txt-link-freetext" \
href="http://www.nuanti.com/">http://www.nuanti.com</a> the browser experts
</pre>
  </div>

</blockquote></div><br></body></html>



_______________________________________________
cfe-dev mailing list
cfe-dev@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic