[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-dev
Subject:    [cfe-dev] clang: good catch...
From:       Fons Rademakers <Fons.Rademakers () cern ! ch>
Date:       2010-10-22 19:23:06
Message-ID: 4CC1E49A.3060607 () cern ! ch
[Download RAW message or body]

Hi,

  here a nice catch made by clang in out code:

x.cxx:226:19: warning: expression result unused
if (ref||!TFile::Open("file.root"),"CACHEREAD") {

only clang found this, not a single other compiler are other static 
analyzers (and we use most compilers available in the world)!!

The correct code is:

if (ref||!TFile::Open("file.root","CACHEREAD")) {

Cheers, Fons.

-- 
Org:    CERN, European Laboratory for Particle Physics.
Mail:   1211 Geneve 23, Switzerland
E-Mail: Fons.Rademakers@cern.ch              Phone: +41 22 7679248
WWW:    http://fons.rademakers.org           Fax:   +41 22 7669640
_______________________________________________
cfe-dev mailing list
cfe-dev@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
[prev in list] [next in list] [prev in thread] [next in thread]