[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave
From:       Maíra_Canal_via_Phabricator via cfe-commits <cfe-commits () lists ! 
Date:       2022-11-30 20:18:01
Message-ID: whke6jk2SD-8EtD2lDMGcw () geopod-ismtpd-4-3
[Download RAW message or body]

mairacanal added a comment.

In D139029#3961372 <https://reviews.llvm.org/D139029#3961372>, @HazardyKnusperkeks \
wrote:

> Can you please add a test with more than one newline?

Hi @HazardyKnusperkeks! Thanks for the feedback. It looks like \
`Changes[i].NewlinesBefore` values 1 even if I put multiple lines before the comment. \
Do you have any input on what could be causing this? From my point of view, it looks \
like the extra new lines are being removed before `alignTrailingComments` and then \
`Changes[i].NewlinesBefore = 1`, but I'm not really sure how to solve it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139029/new/

https://reviews.llvm.org/D139029

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]