[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size
From:       Zequan Wu via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2020-11-30 22:27:16
Message-ID: xbNunG_0RzejvtBO67PbKw () ismtpd0084p1mdw1 ! sendgrid ! net
[Download RAW message or body]

zequanwu added a comment.

In D91673#2401578 <https://reviews.llvm.org/D91673#2401578>, @xur wrote:

> This is probably OK for -Os (SizeLevel == 1), but we need to be careful with Oz \
> (SizeLevel == 2). We already know that enabling preinliner in general will reduce \
> size -- as the preinliner is pretty conservative. But there will be cases size will \
> be increased. 
> I would like more test results (like bootstrap clang) before committing.

I don't see binary size difference (<1%), when bootstrap clang with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91673/new/

https://reviews.llvm.org/D91673

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]