[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS
From:       Reid Kleckner via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2020-11-30 21:32:17
Message-ID: z89X80asS0e4YLh1etG0FQ () ismtpd0029p1iad2 ! sendgrid ! net
[Download RAW message or body]

rnk added a comment.

Windows has effectively always had stack clash protection: we've always emitted those \
little chkstk probe calls for stack frames larger than a page. Would it make more \
sense to ignore this flag on Windows, since it opts into always-on behavior? If so, \
this doesn't seem like the right place to ignore it.

I see your comment here, but I don't really understand it:
https://reviews.llvm.org/D92100#2422729
What goes wrong on Windows? Can it be made to just work instead? It should be simple.

How do things go wrong on Darwin? I was under the impression that this was \
implemented in LLVM as strictly inline code, no runtime support required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92245/new/

https://reviews.llvm.org/D92245

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]