[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT
From:       Hubert Tong via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2020-05-31 21:06:31
Message-ID: 1341f942b9f14a03a74e25d21eb8ddb3 () localhost ! localdomain
[Download RAW message or body]

hubert.reinterpretcast marked 3 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:452
       CmdArgs.push_back("-dynamic-linker");
-      CmdArgs.push_back(Args.MakeArgString(Loader));
+      CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) +
+                                           ToolChain.getDynamicLinker(Args)));
----------------
hubert.reinterpretcast wrote:
> nemanjai wrote:
> > Is this just an orthogonal NFC change? If so, can you please commit it separately \
> > in an NFC commit?
> Yes; all of the other changes made around here disappeared during the development \
> process. Would it be okay to split it out on the commit instead of updating the \
> patch?
The NFC change has be separately committed under rGc15d5d12c625.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80300/new/

https://reviews.llvm.org/D80300



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]