[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check
From:       Nathan James via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2020-05-31 14:58:19
Message-ID: 155ff377abbb10be9a77d3c64aebbab6 () localhost ! localdomain
[Download RAW message or body]

njames93 marked an inline comment as done.
njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21
 
+// FIXME: Add any more builtin variadics that shouldn't trigger this
+static constexpr StringRef AllowedVariadics[] = {
----------------
aaron.ballman wrote:
> How would we know which builtins should or should not trigger this? Can we add that \
> information to this comment (or, better yet, just fix the fixme up front)?
Good point, its more a case that I don't know all the variadic builtins clang \
supports. Those ones I included are just the ones you find in the gcc documentation. \
Shall I just remove the Fixme completely, If there is another one that's been missed \
we can address that later


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80887/new/

https://reviews.llvm.org/D80887



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]