[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support
From:       Michael Forster via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2019-11-30 22:21:03
Message-ID: e66fff174985651883dcd693b9178f66 () localhost ! localdomain
[Download RAW message or body]

MForster marked an inline comment as done.
MForster added inline comments.


================
Comment at: clang-tools-extra/clangd/test/document-link.test:21
+# CHECK-NEXT:      },
+# CHECK-NEXT:      "target": "file://{{.*}}/iostream"
+# CHECK-NEXT:    },
----------------
Originally I tried to add a header file to the setup with a second didOpen request, \
but I didn't get this to work. Would I need to set this up like \
`background-index.test`, or is there a simpler way?

Anyway, I think the regular expression is probably good enough for the purpose of \
this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70872/new/

https://reviews.llvm.org/D70872



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]