[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D56066: [OpenCL] Address space for default class members
From:       John McCall via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2018-12-31 20:49:08
Message-ID: f9458c12d85bf05d9265c5a10de37e61 () localhost ! localdomain
[Download RAW message or body]

rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGCall.cpp:78
+    RecTy = Context.getAddrSpaceQualType(
+        RecTy, MD->getTypeQualifiers().getAddressSpace());
   return Context.getPointerType(CanQualType::CreateUnsafe(RecTy));
----------------
Would you mind making a patch to rename this (and the method on `FunctionProtoType`) \
to something like `getMethodQualifiers`?  It can be a follow-up instead of blocking \
this.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:12649
+    ArgType = Context.getAddrSpaceQualType(ClassType, LangAS::opencl_generic);
+  ArgType = Context.getRValueReferenceType(ClassType);
 
----------------
You're implicitly dropping the address space qualifier here by going back to \
`ClassType`.


================
Comment at: lib/Sema/SemaInit.cpp:4539
+  if (InitCategory.isPRValue() || InitCategory.isXValue())
+    T1Quals.removeAddressSpace();
+
----------------
I can understand why a pr-value wouldn't have an address space, but an x-value's \
address space is surely important.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56066/new/

https://reviews.llvm.org/D56066



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]