[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D56113: [OpenMP] Replace predetermined shared for const variable
From:       Alexey Bataev via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2018-12-31 18:17:18
Message-ID: 101aa59e8f8da9dbb0cd4069625f6634 () localhost ! localdomain
[Download RAW message or body]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:9702
 
+static bool RejectConstNotMutableType(Sema &SemaRef, ValueDecl *D,
+                                      OpenMPClauseKind CKind,
----------------
Functions must start from the small letters.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:9716
+                      RD->hasDefinition() && RD->hasMutableFields())) {
+    SemaRef.Diag(ELoc, SemaRef.getLangOpts().CPlusPlus
+                           ? diag::err_omp_const_not_mutable_variable
----------------
I would check here for `RD` rather than `CPlusPlus`. `int` types cannot have mutable fields, for example.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56113/new/

https://reviews.llvm.org/D56113



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]