[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'
From:       Alex Strelnikov via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2018-10-31 22:44:34
Message-ID: 23216015c01bc8d99378ef7b65e30e51 () localhost ! localdomain
[Download RAW message or body]

astrelni added inline comments.


================
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:151-152
+  const auto *ArgExpr = Result.Nodes.getNodeAs<Expr>("arg");
+  llvm::StringRef Message = "perform explicit cast on expression getting "
+                            "implicitly converted to int64_t";
+
----------------
aaron.ballman wrote:
> How about: `"implicit conversion to 'int64_t' is deprecated in this context; use an \
> explicit cast instead"`
Forgot to say thanks, this is much better :)


https://reviews.llvm.org/D53830



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]