[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields
From:       Eli Friedman via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2018-02-28 21:39:30
Message-ID: 2f55fd7c3aaa78b436ef4bf3ce51fa2a () localhost ! localdomain
[Download RAW message or body]

efriedma added inline comments.


================
Comment at: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp:1758
+             Context.getTargetInfo().getTriple().isWindowsGNUEnvironment()) &&
+            "Non PowerOf2 size outside of GNU mode");
+        if (TypeSize > FieldAlign &&
----------------
mstorsjo wrote:
> efriedma wrote:
> > This assertion seems weird.  `sizeof(long double)` is 12 for other targets, \
> > including x86-32 Linux.
> Perhaps it'd make more sense to flip it around, `assert(isPowerOf2() || \
> !Triple.isWindowsMSVCEnvironment())`?
Yes, that makes sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D43734



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]