[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    RE: [PATCH] D34158: For standards compatibility, preinclude <stdc-predef.h> if the file is available
From:       "Blower, Melanie via cfe-commits" <cfe-commits () lists ! llvm ! org>
Date:       2017-07-31 21:18:44
Message-ID: B3584E72CFEBED439A3ECA9BCE67A4EF6B10A0AB () fmsmsx116 ! amr ! corp ! intel ! com
[Download RAW message or body]

 
fedor.sergeev added inline comments.


================
Comment at: test/Driver/stdc-predef.c:15
+  /* In this test, the file stdc-predef.h is missing from the 
+installation */ #if _STDC_PREDEF_H
+  #error "stdc-predef.h should not be included"
----------------
I would rather see a real check on include file inclusion (say, checking -H output) \
than a check for a macro. Exact macro guard name is not a public interface at all. \
You might be lucky with current stdc-predef.h on Linux, but on other platforms it \
could be named differently.
> Thanks Fedor.  I am uploading a new patch with an updated version of this test \
> case. Please see comments in the new patch.

Repository:
  rL LLVM

https://reviews.llvm.org/D34158



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]