[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.
From:       Eugene Zelenko via Phabricator via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2016-11-30 23:57:41
Message-ID: f58e96fc1d4c549f6ed5fc8dbe31e881 () localhost ! localdomain
[Download RAW message or body]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst:6
+
+Finds calls to math.h functions with implicit float to double promotions.
+
----------------
jlebar wrote:
> Eugene.Zelenko wrote:
> > Please enclose math.h, float and double into ``.
> > 
> > Will be good idea to mention cmath too.
> > Please enclose math.h, float and double into ``.
> 
> Done.  I used two backticks, I hope that's the right thing.
> 
> > Will be good idea to mention cmath too.
> 
> What about cmath, exactly?
cmath is proper C++ header for math functions prototypes.


https://reviews.llvm.org/D27284



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]