[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    [PATCH] D25624: Added 'inline' attribute to basic_string's destructor
From:       Mehdi AMINI via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2016-10-31 22:42:59
Message-ID: 6cb70de09538797727a69e39cbf4e8f5 () localhost ! localdomain
[Download RAW message or body]

mehdi_amini added a comment.

In https://reviews.llvm.org/D25624#583883, @sebpop wrote:

> In https://reviews.llvm.org/D25624#583163, @mehdi_amini wrote:
> 
> > I'd like to understand why only the destructor?
> 
> 
> We have committed a patch to inline the constructor of std::string.
> Do you think we should inline some other functions?


I'd say all of them (unless there's a reason to not do) :)
So: default to the inline keyword, with possibility of opt-out on a case by case.

The only impact of the inline attribute, as I understand, is to make sure some IR is \
emitted. There won't be any codegen, and the compile-time impact should be \
reasonnable.


https://reviews.llvm.org/D25624



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]