[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP stor
From:       Peter Collingbourne via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2016-04-30 21:27:13
Message-ID: 8fc5ce64745a9a8efc97ea60c00f8f3c () localhost ! localdomain
[Download RAW message or body]

pcc added a comment.

You should be using `-target x86-unknown-contiki` or similar. That should tune the \
behaviour to what is required for that OS. See what we have in \
`TargetLoweringBase::getSafeStackPointerLocation` to provide Android-specific \
behaviour for example.

The existence of flags is not justification to add more. Besides, it appears that the \
`-safe-stack-usp-storage` flag was added without proper review. It was reviewed in \
http://reviews.llvm.org/D15673, but the mailing list was not added as a subscriber. \
If I had been aware of that review I would have made the same objections at that \
time.


http://reviews.llvm.org/D19483



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]