[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.
From:       Richard Smith via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2016-03-03 2:31:57
Message-ID: 8879a164c9d8f0176423cd1f69c64536 () localhost ! localdomain
[Download RAW message or body]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Sorry for the delay, LGTM


================
Comment at: lib/Sema/SemaExpr.cpp:377
@@ +376,3 @@
+  auto *DRD = dyn_cast<OMPDeclareReductionDecl>(CurContext);
+  if ((LangOpts.OpenMP != 0u) && (DRD != nullptr) &&
+      !CurContext->containsDecl(D) && isa<VarDecl>(D)) {
----------------
`(LangOpts.OpenMP != 0u)` -> `LangOpts.OpenMP`
`(DRD != nullptr)` -> `DRD`

================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2494
@@ +2493,3 @@
+  auto *PrevDeclInScope = D->getPrevDeclInScope();
+  if ((PrevDeclInScope != nullptr) && !PrevDeclInScope->isInvalidDecl()) {
+    PrevDeclInScope = cast<OMPDeclareReductionDecl>(
----------------
`(PrevDeclInScope != nullptr)` -> `PrevDeclInScope`


http://reviews.llvm.org/D11182



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]