[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.
From:       "hfinkel () anl ! gov via cfe-commits" <cfe-commits () lists ! llvm ! org>
Date:       2015-10-27 18:11:52
Message-ID: 18d676fc332316fe81bb66606663f2f3 () localhost ! localdomain
[Download RAW message or body]

hfinkel added inline comments.

================
Comment at: include/clang/Basic/DiagnosticParseKinds.td:995
@@ -994,1 +994,3 @@
+def err_omp_expected_reduction_identifier : Error<
+  "expected identifier or one of the following operators: '+', '-', '*', '&', '|', '^', '&&' and '||'">;
 
----------------
We're not incredibly consistent here, but I think this reads better if we say:

  '&&', or '||'

instead of:

  '&&' and '||'

(adding the Oxford comma and 'and' -> 'or').

================
Comment at: lib/AST/Decl.cpp:1463
@@ -1461,1 +1462,3 @@
 
+  // Declare reduction are always replaceable.
+  if (OMPDeclareReductionDecl::classofKind(NewK))
----------------
are -> is


http://reviews.llvm.org/D11182



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]