[prev in list] [next in list] [prev in thread] [next in thread]
List: cfe-commits
Subject: Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=
From: Richard Smith via cfe-commits <cfe-commits () lists ! llvm ! org>
Date: 2015-08-25 18:01:29
Message-ID: CAOfiQqk32Pn3MTjO0_XQBwP_TSLuKESp1OpQ+GYxKPOnKU7oUA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
filcab+llvm.phabricator@gmail.com> wrote:
>
> Hi Richard,
>
> We wouldn't be able to link with libs matching
"libinker=*.{dylib,so,...}", I guess. If that is a big problem and you'd
prefer that we keep this as a private patch, let me know.
I don't think it's a big problem, more just a "try to pick better flag
names in future" comment :) It sounds like you guys have existing systems
that depend on this name, so while I'm not really overjoyed about this,
accepting it for compatibility seems OK.
Can we produce an accompanying "deprecated" warning suggesting use of the
other name?
> Thank you,
>
> Filipe
>
>
> On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith <richard@metafoo.co.uk>
wrote:
>>
>> On Mon, Aug 24, 2015 at 5:50 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>>>
>>> echristo added inline comments.
>>>
>>> ================
>>> Comment at: include/clang/Driver/Options.td:1853
>>> @@ -1853,1 +1852,3 @@
>>> +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker
<name>">, Group<f_Group>;
>>> +def linker_EQ : Joined<["-"], "linker=">, Alias<fuse_ld_EQ>,
MetaVarName<"<name>">;
>>>
>>> ----------------
>>> thakis wrote:
>>> > Any reason to have another alias for this at all? Does gcc understand
this spelling? If not, could you limit this flag to PS4 targets? (I'm
guessing you need it for PS4 targets for some reason.)
>>> Any reason? (And I'm not sure how to limit it btw on target).
>>
>>
>> -l already has a meaning; adding a different flag starting with -l is a
bad idea.
>
>
[Attachment #5 (text/html)]
<p dir="ltr">On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <<a \
href="mailto:filcab%2Bllvm.phabricator@gmail.com">filcab+llvm.phabricator@gmail.com</a>> \
wrote:<br> ><br>
> Hi Richard,<br>
><br>
> We wouldn't be able to link with libs matching \
"libinker=*.{dylib,so,...}", I guess. If that is a big problem and \
you'd prefer that we keep this as a private patch, let me know.</p> <p \
dir="ltr">I don't think it's a big problem, more just a "try to pick \
better flag names in future" comment :) It sounds like you guys have existing \
systems that depend on this name, so while I'm not really overjoyed about this, \
accepting it for compatibility seems OK.</p> <p dir="ltr">Can we produce an \
accompanying "deprecated" warning suggesting use of the other name?</p> <p \
dir="ltr">> Thank you,<br> ><br>
> Filipe<br>
><br>
><br>
> On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith <<a \
href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br> \
>><br> >> On Mon, Aug 24, 2015 at 5:50 PM, Eric Christopher via \
cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> \
wrote:<br> >>><br>
>>> echristo added inline comments.<br>
>>><br>
>>> ================<br>
>>> Comment at: include/clang/Driver/Options.td:1853<br>
>>> @@ -1853,1 +1852,3 @@<br>
>>> +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, \
HelpText<"Use linker <name>">, Group<f_Group>;<br> \
>>> +def linker_EQ : Joined<["-"], "linker=">, \
Alias<fuse_ld_EQ>, MetaVarName<"<name>">;<br> \
>>><br> >>> ----------------<br>
>>> thakis wrote:<br>
>>> > Any reason to have another alias for this at all? Does gcc \
understand this spelling? If not, could you limit this flag to PS4 targets? (I'm \
guessing you need it for PS4 targets for some reason.)<br> >>> Any reason? \
(And I'm not sure how to limit it btw on target).<br> >><br>
>><br>
>> -l already has a meaning; adding a different flag starting with -l is a bad \
idea.<br> ><br>
><br>
</p>
[Attachment #6 (text/plain)]
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic