[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11658: [Sema] main can't be declared as global variable
From:       Richard Smith via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2015-08-14 23:50:22
Message-ID: CAOfiQqnUs2dyS6hMzeG0y9+vLkJXr7aCAGNo6HSq5O+0OKUpyQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, Aug 14, 2015 at 7:15 AM, Davide Italiano <dccitaliano@gmail.com>
wrote:

> davide added a comment.
>
> Oops, I uploaded the wrong diff. Anyway, I changed can't to cannot and
> committed this as r245051.
> While looking at DiagnosticSemaKind.td I noticed there are still 7
> diagnostics that use can't instead of cannot. Are you OK if I change those?
> (in a subsequent commit, of course)
>

Sure, it seems better to be consistent.


> http://reviews.llvm.org/D11658
>
>
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 14, 2015 \
at 7:15 AM, Davide Italiano <span dir="ltr">&lt;<a \
href="mailto:dccitaliano@gmail.com" \
target="_blank">dccitaliano@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">davide added a comment.<br> <br>
Oops, I uploaded the wrong diff. Anyway, I changed can&#39;t to cannot and committed \
this as r245051.<br> While looking at DiagnosticSemaKind.td I noticed there are still \
7 diagnostics that use can&#39;t instead of cannot. Are you OK if I change those? (in \
a subsequent commit, of course)<br></blockquote><div><br></div><div>Sure, it seems \
better to be consistent.</div><div>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <a \
href="http://reviews.llvm.org/D11658" rel="noreferrer" \
target="_blank">http://reviews.llvm.org/D11658</a><br> <br>
<br>
<br>
</blockquote></div><br></div></div>


[Attachment #6 (text/plain)]

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]