[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    RE: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++
From:       Sjoerd Meijer via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2015-08-14 16:14:23
Message-ID: 1C23526A7C42DB45BBF55B662C7C530E4E65366E33 () BUNGLE ! Emea ! Arm ! com
[Download RAW message or body]

[Attachment #2 (text/plain)]

Yes, I got confused when clang is in C++ mode. In my patch, I was checking the driver \
status, but that's not the complete story. From these combinations of invoking clang \
with some input:

./clang[++] [-x [c | c++]] myinput.[TY_C | TY_CXX]

I wanted to create a special case for these combinations only:

./clang++ ret.c
./clang -x c++ ret.c
(./clang++ -x c++ ret.c)

Which are the cases when clang is in C++ mode and the file extension is C. For these \
combinations, I wanted to allow this new –fallow-nonreturning-functions flag \
(ignore it for the others cases), thus generate function epilogues which came from a \
request to compile legacy C code with a C++ compiler. I've now modified my patch, and \
I think it was as simple as checking, in pseudo code, "types::isCXX() && \
LookupTypeForExtension() == types::TY_C). However, I won't submit the patch yet \
unless you think it is still useful; I will also see if we can solve this compilation \
of legacy code in a different way.

Regardless of this discussion and new option, not returning from a function is not \
very nice. Probably the best thing is not only generate a trap at optimisation level \
O0, but in all cases? That's a quick and easy fix. Probably the security folks can \
live with this as well as the folks who want to benefit from this UB as an \
optimisation opportunity.

Cheers,
Sjoerd.


From: metafoo@gmail.com [mailto:metafoo@gmail.com] On Behalf Of Richard Smith
Sent: 13 August 2015 19:18
To: Sjoerd Meijer
Cc: Hal Finkel; Marshall Clow; cfe-commits
Subject: Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in \
C++

On Thu, Aug 13, 2015 at 1:52 AM, Sjoerd Meijer \
<Sjoerd.Meijer@arm.com<mailto:Sjoerd.Meijer@arm.com>> wrote: Hi Richard,
Thanks for reviewing. Agree, that was a bit confusing. More specifically,
the warning message was confusing (i.e. wrong). This patch is for compiling .c
input in C++ mode. The new flag should be ignored for C++ *input*, and indeed
not when it is in C++ *mode* as the warning message said earlier. So I have
changed the warning message accordingly and hope that solves it, see attached
patch.

What is the distinction you're trying to draw here? This patch still doesn't make \
sense to me. This flag is only meaningful when compiling as C++. You ignore it when \
compiling as C but produce a warning that says it's ignored when compiling as C++.

Cheers.

From: metafoo@gmail.com<mailto:metafoo@gmail.com> \
                [mailto:metafoo@gmail.com<mailto:metafoo@gmail.com>] On Behalf Of \
                Richard Smith
Sent: 12 August 2015 23:06
To: Sjoerd Meijer
Cc: Hal Finkel; Marshall Clow; cfe-commits

Subject: Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in \
C++

This patch seems a bit confused. You warn that the flag is ignored in C++, but it \
only has an effect in C++. You have a testcase with a .c extension that is built with \
-x c++.

On Wed, Aug 12, 2015 at 5:23 AM, Sjoerd Meijer \
<sjoerd.meijer@arm.com<mailto:sjoerd.meijer@arm.com>> wrote: [ + \
cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> ]

Hi,
The functionality is now available under a flag, see attached patch. Note that the \
flag is ignored in C++ mode, so it will help the use case of compiling (legacy) C \
code with a C++ compiler. Cheers,
Sjoerd.

From: Sjoerd Meijer [mailto:sjoerd.meijer@arm.com]
Sent: 03 August 2015 11:40
To: 'Richard Smith'
Cc: Hal Finkel; Marshall Clow; cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu> \
                Developers; cfe commits
Subject: RE: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in \
C++

Hi Richard,

I agree with your conclusions and will start preparing a patch for option 3) under a \
flag that is off by default; this enables folks to build/run C code in C++. I \
actually think option 2) would be a good one too, but as it is already available \
under a flag I also don't see how useful it is combining options 2) and 3) with \
another (or one more) flag that is off by default.

Cheers.

From: metafoo@gmail.com<mailto:metafoo@gmail.com> [mailto:metafoo@gmail.com] On \
                Behalf Of Richard Smith
Sent: 31 July 2015 19:46
To: Sjoerd Meijer
Cc: Hal Finkel; Marshall Clow; cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu> \
                Developers; cfe commits
Subject: Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in \
C++

On Fri, Jul 31, 2015 at 7:35 AM, Sjoerd Meijer \
<sjoerd.meijer@arm.com<mailto:sjoerd.meijer@arm.com>> wrote: Hi, I am not sure if we \
came to a conclusion. Please find attached a patch. It simply removes the two lines \
that insert an unreachable statement (which cause removal of the return statement). \
Please note that at -O0 the trap instruction is still generated. Is this something we \
could live with?

I don't think this is an improvement:

This doesn't satisfy the folks who want an 'unreachable' for better code size and \
optimization, and it doesn't satisfy the folks who want a guaranteed trap for \
security, and it doesn't satisfy the folks who want their broken code to limp along \
(because it'll still trap at -O0), and it is at best a minor improvement for the \
folks who want missing returns to be more easily debuggable (with -On, the code goes \
wrong in the caller, or appears to work, rather than falling into an unrelated \
function, and debugging this with -O0 was already easy).

I think there are three options that are defensible here:
1) The status quo: this is UB and we treat it as such and optimize on that basis, but \
provide a trap as a convenience at -O0 2) The secure approach: this is UB but we \
always trap 3) Define the behavior to return 'undef' for C types: this allows \
questionable C code that has UB in C++ to keep working when built with a C++ compiler

Note that (3) can be combined with either (1) or (2). (2) is already available via \
the 'return' sanitizer. So this really reduces to: in those cases where C says it's \
OK so long as the caller doesn't look at the returned value (and where the return \
type doesn't have a non-trivial copy constructor or destructor, isn't a reference, \
and so on), should we attempt to preserve the C behaviour? I would be OK with putting \
that behind a `-f` flag (perhaps `-fstrict-return` or similar) to support those folks \
who want to build C code in C++, but I would suggest having that flag be off by \
default, since that is not the usual use case for a C++ compiler.

Cheers,
Sjoerd.

From: cfe-dev-bounces@cs.uiuc.edu<mailto:cfe-dev-bounces@cs.uiuc.edu> \
[mailto:cfe-dev-bounces@cs.uiuc.edu<mailto:cfe-dev-bounces@cs.uiuc.edu>] On Behalf Of \
                Richard Smith
Sent: 29 July 2015 18:07
To: Hal Finkel
Cc: Marshall Clow; cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu> Developers

Subject: Re: [cfe-dev] missing return statement for non-void functions in C++


On Jul 29, 2015 7:43 AM, "Hal Finkel" <hfinkel@anl.gov<mailto:hfinkel@anl.gov>> \
wrote:
> 
> ----- Original Message -----
> > From: "David Blaikie" <dblaikie@gmail.com<mailto:dblaikie@gmail.com>>
> > To: "James Molloy" <james@jamesmolloy.co.uk<mailto:james@jamesmolloy.co.uk>>
> > Cc: "Marshall Clow" <mclow.lists@gmail.com<mailto:mclow.lists@gmail.com>>, \
> >                 "cfe-dev Developers" \
> >                 <cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>>
> > Sent: Wednesday, July 29, 2015 9:15:09 AM
> > Subject: Re: [cfe-dev] missing return statement for non-void functions in C++
> > 
> > 
> > On Jul 29, 2015 7:06 AM, "James Molloy" < \
> > james@jamesmolloy.co.uk<mailto:james@jamesmolloy.co.uk> > wrote:
> > > 
> > > Hi,
> > > 
> > > If we're going to emit a trap instruction (and thus create a broken
> > > binary), why don't we error instead?
> > 
> > We warn, can't error, because it may be dynamically unreached, in
> > which case the program is valid and we can't reject it.
> 
> I think this also explains why this is useful for optimization.
> 
> 1. It is a code-size optimization
> 2. By eliminating unreachable control flow, we can remove branches and tests that \
> are not actual necessary 
> int foo(int x) {
> if (x > 5) return 2*x;
> else if (x < 2) return 3 - x;
> }
> 
> That having been said, there are other ways to express these things, and the \
> situation often represents an error. I'd be fine with requiring a special flag \
> (-fallow-nonreturning-functions or whatever) in order to put the compiler is a \
> truly confirming mode (similar to the situation with sized delete).

Note that we already have a flag to trap on this: -fsanitize-trap=return. (You may \
also need -fsanitize=return, I don't remember.) That seems consistent with how we \
treat most other forms of UB.

> -Hal
> 
> > 
> > > 
> > > James
> > > 
> > > On Wed, 29 Jul 2015 at 15:05 David Blaikie < \
> > > dblaikie@gmail.com<mailto:dblaikie@gmail.com> > wrote:
> > > > 
> > > > 
> > > > On Jul 29, 2015 2:10 AM, "mats petersson" < \
> > > > mats@planetcatfish.com<mailto:mats@planetcatfish.com>
> > > > > wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > On 28 July 2015 at 23:40, Marshall Clow < \
> > > > > mclow.lists@gmail.com<mailto:mclow.lists@gmail.com>
> > > > > > wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Tue, Jul 28, 2015 at 6:14 AM, Sjoerd Meijer <
> > > > > > sjoerd.meijer@arm.com<mailto:sjoerd.meijer@arm.com> > wrote:
> > > > > > > 
> > > > > > > Hi,
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > In C++, the undefined behaviour of a missing return statements
> > > > > > > for a non-void function results in not generating the
> > > > > > > function epilogue (unreachable statement is inserted and the
> > > > > > > return statement is optimised away). Consequently, the
> > > > > > > runtime behaviour is that control is never properly returned
> > > > > > > from this function and thus it starts executing "garbage
> > > > > > > instructions". As this is undefined behaviour, this is
> > > > > > > perfectly fine and according to the spec, and a compile
> > > > > > > warning for this missing return statement is issued. However,
> > > > > > > in C, the behaviour is that a function epilogue is generated,
> > > > > > > i.e. basically by returning uninitialised local variable.
> > > > > > > Codes that rely on this are not beautiful pieces of code, i.e
> > > > > > > are buggy, but it might just be okay if you for example have
> > > > > > > a function that just initialises stuff (and the return value
> > > > > > > is not checked, directly or indirectly); some one might argue
> > > > > > > that not returning from that function might be a bit harsh.
> > > > > > 
> > > > > > 
> > > > > > I would not be one of those people.
> > > > > 
> > > > > 
> > > > > Nor me.
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > So this email is to probe if there would be strong resistance
> > > > > > > to follow the C behaviour? I am not yet sure how, but would
> > > > > > > perhaps a compromise be possible/acceptable to make the
> > > > > > > undefined behaviour explicit and also generate the function
> > > > > > > epilogue?
> > > > > > 
> > > > > > 
> > > > > > "undefined behavior" is exactly that.
> > > > > > 
> > > > > > You have no idea what is going to happen; there are no
> > > > > > restrictions on what the code being executed can do.
> > > > > > 
> > > > > > "it just might be ok" means on a particular version of a
> > > > > > particular compiler, on a particular architecture and OS, at a
> > > > > > particular optimization level. Change any of those things, and
> > > > > > you can change the behavior.
> > > > > 
> > > > > 
> > > > > In fact, the "it works kind of as you expected" is the worst
> > > > > kind of UB in my mind. UB that causes a crash, stops or other
> > > > > "directly obvious that this is wrong" are MUCH easier to debug.
> > > > > 
> > > > > So make this particular kind of UB explicit by crashing or
> > > > > stopping would be a good thing. Making it explicit by
> > > > > "returning kind of nicely, but not correct return value" is
> > > > > about the worst possible result.
> > > > 
> > > > At -O0 clang emits a trap instruction, making it more explicit as
> > > > you suggest. At higher optimization levels it just falls
> > > > through/off.
> > > > 
> > > > > 
> > > > > --
> > > > > Mats
> > > > > > 
> > > > > > 
> > > > > > -- Marshall
> > > > > > 
> > > > > > 
> > > > > > _______________________________________________
> > > > > > cfe-dev mailing list
> > > > > > cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>
> > > > > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> > > > > > 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > cfe-dev mailing list
> > > > > cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>
> > > > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> > > > > 
> > > > 
> > > > _______________________________________________
> > > > cfe-dev mailing list
> > > > cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>
> > > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> > 
> > _______________________________________________
> > cfe-dev mailing list
> > cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev



-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential \
and may also be privileged. If you are not the intended recipient, please notify the \
sender immediately and do not disclose the contents to any other person, use it for \
any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in \
England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn \
Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential \
and may also be privileged. If you are not the intended recipient, please notify the \
sender immediately and do not disclose the contents to any other person, use it for \
any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in \
England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn \
Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782


[Attachment #3 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Tahoma;
	panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
p
	{mso-style-priority:99;
	mso-margin-top-alt:auto;
	margin-right:0cm;
	mso-margin-bottom-alt:auto;
	margin-left:0cm;
	font-size:12.0pt;
	font-family:"Times New Roman","serif";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
	{mso-style-priority:99;
	mso-style-link:"Balloon Text Char";
	margin:0cm;
	margin-bottom:.0001pt;
	font-size:8.0pt;
	font-family:"Tahoma","sans-serif";}
span.EmailStyle18
	{mso-style-type:personal-reply;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
span.BalloonTextChar
	{mso-style-name:"Balloon Text Char";
	mso-style-priority:99;
	mso-style-link:"Balloon Text";
	font-family:"Tahoma","sans-serif";
	mso-fareast-language:EN-GB;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri","sans-serif";
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Yes, \
I got confused when clang is in C&#43;&#43; mode. In my patch, I was checking the \
driver status, but that's not the complete story. From these combinations of  \
invoking clang with some input:<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">./clang[&#43;&#43;] \
[-x [c | c&#43;&#43;]] myinput.[TY_C | TY_CXX]<o:p></o:p></span></p> <p \
class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">I \
wanted to create a special case for these combinations only:<o:p></o:p></span></p> <p \
class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">./clang&#43;&#43; \
ret.c<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">./clang \
-x c&#43;&#43; ret.c<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">(./clang&#43;&#43; \
-x c&#43;&#43; ret.c)<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Which \
are the cases when clang is in C&#43;&#43; mode and the file extension is C. For \
these combinations, I wanted to allow this new –fallow-nonreturning-functions  flag \
(ignore it for the others cases), thus generate function epilogues which came from a \
request to compile legacy C code with a C&#43;&#43; compiler. I've now modified my \
patch, and I think it was as simple as checking, in pseudo code, "types::isCXX() \
&amp;&amp; LookupTypeForExtension()  == types::TY_C). However, I won't submit the \
patch yet unless you think it is still useful; I will also see if we can solve this \
compilation of legacy code in a different way.<o:p></o:p></span></p> <p \
class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Regardless \
of this discussion and new option, not returning from a function is not very nice. \
Probably the best thing is not only generate a trap at optimisation  level O0, but in \
all cases? That's a quick and easy fix. Probably the security folks can live with \
this as well as the folks who want to benefit from this UB as an optimisation \
opportunity.<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Cheers,<o:p></o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Sjoerd.<o:p></o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><b><span lang="EN-US" \
style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span \
lang="EN-US" style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;"> \
metafoo@gmail.com [mailto:metafoo@gmail.com] <b>On Behalf Of </b>Richard Smith<br>
<b>Sent:</b> 13 August 2015 19:18<br>
<b>To:</b> Sjoerd Meijer<br>
<b>Cc:</b> Hal Finkel; Marshall Clow; cfe-commits<br>
<b>Subject:</b> Re: [PATCH] RE: [cfe-dev] missing return statement for non-void \
functions in C&#43;&#43;<o:p></o:p></span></p> <p \
class="MsoNormal"><o:p>&nbsp;</o:p></p> <div>
<div>
<div>
<p class="MsoNormal">On Thu, Aug 13, 2015 at 1:52 AM, Sjoerd Meijer &lt;<a \
href="mailto:Sjoerd.Meijer@arm.com" target="_blank">Sjoerd.Meijer@arm.com</a>&gt; \
wrote:<o:p></o:p></p> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Hi \
Richard,</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Thanks \
for reviewing. Agree, that was a bit confusing. More \
specifically,</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">the \
warning message was confusing (i.e. wrong). This patch is for compiling .c \
</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">input \
in C&#43;&#43; mode. The new flag should be ignored for C&#43;&#43; *<b>input</b>*, \
and indeed </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">not \
when it is in C&#43;&#43; *mode* as the warning message said earlier. So I have \
</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">changed \
the warning message accordingly and hope that solves it, see \
attached</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">patch.</span><o:p></o:p></p>
 </div>
</div>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">What is the distinction you're trying to draw here? This patch \
still doesn't make sense to me. This flag is only meaningful when compiling as \
C&#43;&#43;. You ignore it when compiling as C but produce a warning that says it's \
ignored when compiling  as C&#43;&#43;.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">&nbsp;<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm \
6.0pt;margin-left:4.8pt;margin-right:0cm"> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Cheers.</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US" \
style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span \
lang="EN-US" style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">
 <a href="mailto:metafoo@gmail.com" target="_blank">metafoo@gmail.com</a> [mailto:<a \
href="mailto:metafoo@gmail.com" target="_blank">metafoo@gmail.com</a>] <b>On Behalf \
Of </b>Richard Smith<br> <b>Sent:</b> 12 August 2015 23:06<br>
<b>To:</b> Sjoerd Meijer<br>
<b>Cc:</b> Hal Finkel; Marshall Clow; cfe-commits</span><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
<b>Subject:</b> Re: [PATCH] RE: [cfe-dev] missing return statement for non-void \
functions in C&#43;&#43;<o:p></o:p></p> </div>
</div>
<div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
<div> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">This patch seems a bit \
confused. You warn that the flag is ignored in C&#43;&#43;, but it only has an effect \
in C&#43;&#43;. You have a testcase with a .c extension that is built with -x \
c&#43;&#43;.<o:p></o:p></p> <div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
<div> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Wed, Aug 12, 2015 at \
5:23 AM, Sjoerd Meijer &lt;<a href="mailto:sjoerd.meijer@arm.com" \
target="_blank">sjoerd.meijer@arm.com</a>&gt; wrote:<o:p></o:p></p> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">[ \
&#43; <a href="mailto:cfe-commits@lists.llvm.org" \
target="_blank">cfe-commits@lists.llvm.org</a> ]</span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Hi,</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">The \
functionality is now available under a flag, see attached patch. Note that the flag \
is ignored  in C&#43;&#43; mode, so it will help the use case of compiling (legacy) C \
code with a C&#43;&#43; compiler.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Cheers,</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Sjoerd.</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US" \
style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span \
lang="EN-US" style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;"> \
Sjoerd  Meijer [<a href="mailto:sjoerd.meijer@arm.com" \
target="_blank">mailto:sjoerd.meijer@arm.com</a>] <br>
<b>Sent:</b> 03 August 2015 11:40<br>
<b>To:</b> 'Richard Smith'<br>
<b>Cc:</b> Hal Finkel; Marshall Clow; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank"> cfe-dev@cs.uiuc.edu</a> Developers; cfe commits<br>
<b>Subject:</b> RE: [PATCH] RE: [cfe-dev] missing return statement for non-void \
functions in C&#43;&#43;</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Hi \
Richard,</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">I \
agree with your conclusions and will start preparing a patch for option 3) under a \
flag that is  off by default; this enables folks to build/run C code in C&#43;&#43;. \
I actually think option 2) would be a good one too, but as it is already available \
under a flag I also don't see how useful it is combining options 2) and 3) with \
another (or one more) flag that  is off by default.</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Cheers.</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US" \
style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span \
lang="EN-US" style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">
 <a href="mailto:metafoo@gmail.com" target="_blank">metafoo@gmail.com</a> [<a \
href="mailto:metafoo@gmail.com" target="_blank">mailto:metafoo@gmail.com</a>] <b>On \
Behalf Of </b>Richard Smith<br> <b>Sent:</b> 31 July 2015 19:46<br>
<b>To:</b> Sjoerd Meijer<br>
<b>Cc:</b> Hal Finkel; Marshall Clow; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank"> cfe-dev@cs.uiuc.edu</a> Developers; cfe commits<br>
<b>Subject:</b> Re: [PATCH] RE: [cfe-dev] missing return statement for non-void \
functions in C&#43;&#43;</span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
<div> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On \
Fri, Jul 31, 2015 at 7:35 AM, Sjoerd Meijer &lt;<a \
href="mailto:sjoerd.meijer@arm.com" target="_blank">sjoerd.meijer@arm.com</a>&gt; \
wrote:<o:p></o:p></p> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Hi, \
I am not sure if we came to a conclusion. Please find attached a patch. It simply \
removes the  two lines that insert an unreachable statement (which cause removal of \
the return statement). Please note that at -O0 the trap instruction is still \
generated. Is this something we could live with?</span><o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I \
don't think this is an improvement:<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">This \
doesn't satisfy the folks who want an 'unreachable' for better code size and \
optimization, and it doesn't satisfy the folks who want a guaranteed trap for \
security, and it  doesn't satisfy the folks who want their broken code to limp along \
(because it'll still trap at -O0), and it is at best a minor improvement for the \
folks who want missing returns to be more easily debuggable (with -On, the code goes \
wrong in the caller, or  appears to work, rather than falling into an unrelated \
function, and debugging this with -O0 was already easy).<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I \
think there are three options that are defensible here:<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">1) \
The status quo: this is UB and we treat it as such and optimize on that basis, but \
provide a trap as a convenience at -O0<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">2) \
The secure approach: this is UB but we always trap<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">3) \
Define the behavior to return 'undef' for C types: this allows questionable C code \
that has UB in C&#43;&#43; to keep working when built with a C&#43;&#43; \
compiler<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Note \
that (3) can be combined with either (1) or (2). (2) is already available via the \
'return' sanitizer. So this really reduces to: in those cases where C says it's OK so \
long  as the caller doesn't look at the returned value (and where the return type \
doesn't have a non-trivial copy constructor or destructor, isn't a reference, and so \
on), should we attempt to preserve the C behaviour? I would be OK with putting that \
behind a `-f`  flag (perhaps `-fstrict-return` or similar) to support those folks who \
want to build C code in C&#43;&#43;, but I would suggest having that flag be off by \
default, since that is not the usual use case for a C&#43;&#43; \
compiler.<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm \
0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> \
<div> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Cheers,</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">Sjoerd.</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;;color:#1F497D">&nbsp;</span><o:p></o:p></p>
 <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US" \
style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">From:</span></b><span \
lang="EN-US" style="font-size:10.0pt;font-family:&quot;Tahoma&quot;,&quot;sans-serif&quot;">
 <a href="mailto:cfe-dev-bounces@cs.uiuc.edu" \
target="_blank">cfe-dev-bounces@cs.uiuc.edu</a> [mailto:<a \
href="mailto:cfe-dev-bounces@cs.uiuc.edu" \
target="_blank">cfe-dev-bounces@cs.uiuc.edu</a>] <b>On Behalf Of </b>Richard \
Smith<br> <b>Sent:</b> 29 July 2015 18:07<br>
<b>To:</b> Hal Finkel<br>
<b>Cc:</b> Marshall Clow; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank">cfe-dev@cs.uiuc.edu</a> Developers</span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><br>
<b>Subject:</b> Re: [cfe-dev] missing return statement for non-void functions in \
C&#43;&#43;<o:p></o:p></p> </div>
</div>
<div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
<p>On Jul 29, 2015 7:43 AM, &quot;Hal Finkel&quot; &lt;<a \
href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>&gt; wrote:<br> \
&gt;<br> &gt; ----- Original Message -----<br>
&gt; &gt; From: &quot;David Blaikie&quot; &lt;<a href="mailto:dblaikie@gmail.com" \
target="_blank">dblaikie@gmail.com</a>&gt;<br> &gt; &gt; To: &quot;James Molloy&quot; \
&lt;<a href="mailto:james@jamesmolloy.co.uk" \
target="_blank">james@jamesmolloy.co.uk</a>&gt;<br> &gt; &gt; Cc: &quot;Marshall \
Clow&quot; &lt;<a href="mailto:mclow.lists@gmail.com" \
target="_blank">mclow.lists@gmail.com</a>&gt;, &quot;cfe-dev Developers&quot; &lt;<a \
href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>&gt;<br> \
&gt; &gt; Sent: Wednesday, July 29, 2015 9:15:09 AM<br> &gt; &gt; Subject: Re: \
[cfe-dev] missing return statement for non-void functions in C&#43;&#43;<br> &gt; \
&gt;<br> &gt; &gt;<br>
&gt; &gt; On Jul 29, 2015 7:06 AM, &quot;James Molloy&quot; &lt; <a \
href="mailto:james@jamesmolloy.co.uk" target="_blank"> james@jamesmolloy.co.uk</a> \
&gt;<br> &gt; &gt; wrote:<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Hi,<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; If we're going to emit a trap instruction (and thus create a \
broken<br> &gt; &gt; &gt; binary), why don't we error instead?<br>
&gt; &gt;<br>
&gt; &gt; We warn, can't error, because it may be dynamically unreached, in<br>
&gt; &gt; which case the program is valid and we can't reject it.<br>
&gt;<br>
&gt; I think this also explains why this is useful for optimization.<br>
&gt;<br>
&gt; &nbsp;1. It is a code-size optimization<br>
&gt; &nbsp;2. By eliminating unreachable control flow, we can remove branches and \
tests that are not actual necessary<br> &gt;<br>
&gt; int foo(int x) {<br>
&gt; &nbsp; if (x &gt; 5) return 2*x;<br>
&gt; &nbsp; else if (x &lt; 2) return 3 - x;<br>
&gt; }<br>
&gt;<br>
&gt; That having been said, there are other ways to express these things, and the \
situation often represents an error. I'd be fine with requiring a special flag \
(-fallow-nonreturning-functions or whatever) in order to put the compiler is a truly \
confirming mode  (similar to the situation with sized delete).<o:p></o:p></p>
<p>Note that we already have a flag to trap on this: -fsanitize-trap=return. (You may \
also need -fsanitize=return, I don't remember.) That seems consistent with how we \
treat most other forms of UB.<o:p></o:p></p> <p>&gt; &nbsp;-Hal<br>
&gt;<br>
&gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; James<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; On Wed, 29 Jul 2015 at 15:05 David Blaikie &lt; <a \
href="mailto:dblaikie@gmail.com" target="_blank"> dblaikie@gmail.com</a> &gt;<br>
&gt; &gt; &gt; wrote:<br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; On Jul 29, 2015 2:10 AM, &quot;mats petersson&quot; &lt; <a \
href="mailto:mats@planetcatfish.com" target="_blank"> mats@planetcatfish.com</a><br>
&gt; &gt; &gt;&gt; &gt; wrote:<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; On 28 July 2015 at 23:40, Marshall Clow &lt; <a \
href="mailto:mclow.lists@gmail.com" target="_blank"> mclow.lists@gmail.com</a><br>
&gt; &gt; &gt;&gt; &gt; &gt; wrote:<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; On Tue, Jul 28, 2015 at 6:14 AM, Sjoerd Meijer &lt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; <a href="mailto:sjoerd.meijer@arm.com" \
target="_blank">sjoerd.meijer@arm.com</a> &gt; wrote:<br> &gt; &gt; &gt;&gt; \
&gt;&gt;&gt;<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; Hi,<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt; In C&#43;&#43;, the undefined behaviour of a missing \
return statements<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; for a non-void function results \
in not generating the<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; function epilogue \
(unreachable statement is inserted and the<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; return \
statement is optimised away). Consequently, the<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; \
runtime behaviour is that control is never properly returned<br> &gt; &gt; &gt;&gt; \
&gt;&gt;&gt; from this function and thus it starts executing "garbage<br> &gt; &gt; \
&gt;&gt; &gt;&gt;&gt; instructions". As this is undefined behaviour, this is<br> &gt; \
&gt; &gt;&gt; &gt;&gt;&gt; perfectly fine and according to the spec, and a \
compile<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; warning for this missing return statement \
is issued. However,<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; in C, the behaviour is that a \
function epilogue is generated,<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; i.e. basically by \
returning uninitialised local variable.<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; Codes \
that rely on this are not beautiful pieces of code, i.e<br> &gt; &gt; &gt;&gt; \
&gt;&gt;&gt; are buggy, but it might just be okay if you for example have<br> &gt; \
&gt; &gt;&gt; &gt;&gt;&gt; a function that just initialises stuff (and the return \
value<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; is not checked, directly or indirectly); \
some one might argue<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; that not returning from that \
function might be a bit harsh.<br> &gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; I would not be one of those people.<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; Nor me.<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;&gt; So this email is to probe if there would be strong \
resistance<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; to follow the C behaviour? I am not \
yet sure how, but would<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; perhaps a compromise be \
possible/acceptable to make the<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; undefined \
behaviour explicit and also generate the function<br> &gt; &gt; &gt;&gt; &gt;&gt;&gt; \
epilogue?<br> &gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; &quot;undefined behavior&quot; is exactly that.<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; You have no idea what is going to happen; there are \
no<br> &gt; &gt; &gt;&gt; &gt;&gt; restrictions on what the code being executed can \
do.<br> &gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; &quot;it just might be ok&quot; means on a particular \
version of a<br> &gt; &gt; &gt;&gt; &gt;&gt; particular compiler, on a particular \
architecture and OS, at a<br> &gt; &gt; &gt;&gt; &gt;&gt; particular optimization \
level. Change any of those things, and<br> &gt; &gt; &gt;&gt; &gt;&gt; you can change \
the behavior.<br> &gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; In fact, the &quot;it works kind of as you expected&quot; is \
the worst<br> &gt; &gt; &gt;&gt; &gt; kind of UB in my mind. UB that causes a crash, \
stops or other<br> &gt; &gt; &gt;&gt; &gt; &quot;directly obvious that this is \
wrong&quot; are MUCH easier to debug.<br> &gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; So make this particular kind of UB explicit by crashing \
or<br> &gt; &gt; &gt;&gt; &gt; stopping would be a good thing. Making it explicit \
by<br> &gt; &gt; &gt;&gt; &gt; &quot;returning kind of nicely, but not correct return \
value&quot; is<br> &gt; &gt; &gt;&gt; &gt; about the worst possible result.<br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; At -O0 clang emits a trap instruction, making it more explicit \
as<br> &gt; &gt; &gt;&gt; you suggest. At higher optimization levels it just \
falls<br> &gt; &gt; &gt;&gt; through/off.<br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; --<br>
&gt; &gt; &gt;&gt; &gt; Mats<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; -- Marshall<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; &gt;&gt; _______________________________________________<br>
&gt; &gt; &gt;&gt; &gt;&gt; cfe-dev mailing list<br>
&gt; &gt; &gt;&gt; &gt;&gt; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank">cfe-dev@cs.uiuc.edu</a><br> &gt; &gt; &gt;&gt; &gt;&gt; <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank"> \
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br> &gt; &gt; &gt;&gt; \
&gt;&gt;<br> &gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt; &gt; _______________________________________________<br>
&gt; &gt; &gt;&gt; &gt; cfe-dev mailing list<br>
&gt; &gt; &gt;&gt; &gt; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank">cfe-dev@cs.uiuc.edu</a><br> &gt; &gt; &gt;&gt; &gt; <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank"> \
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br> &gt; &gt; &gt;&gt; &gt;<br>
&gt; &gt; &gt;&gt;<br>
&gt; &gt; &gt;&gt; _______________________________________________<br>
&gt; &gt; &gt;&gt; cfe-dev mailing list<br>
&gt; &gt; &gt;&gt; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank">cfe-dev@cs.uiuc.edu</a><br> &gt; &gt; &gt;&gt; <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank"> \
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br> &gt; &gt;<br>
&gt; &gt; _______________________________________________<br>
&gt; &gt; cfe-dev mailing list<br>
&gt; &gt; <a href="mailto:cfe-dev@cs.uiuc.edu" \
target="_blank">cfe-dev@cs.uiuc.edu</a><br> &gt; &gt; <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" \
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br> &gt; \
&gt;<br> &gt;<br>
&gt; --<br>
&gt; Hal Finkel<br>
&gt; Assistant Computational Scientist<br>
&gt; Leadership Computing Facility<br>
&gt; Argonne National Laboratory<br>
&gt;<br>
&gt; _______________________________________________<br>
&gt; cfe-dev mailing list<br>
&gt; <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
&gt; <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" \
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><o:p></o:p></p> \
</div> </div>
</div>
</blockquote>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> </div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">&nbsp;<o:p></o:p></p> \
</div> </div>
</div>
</div>
</div>
<p class="MsoNormal"><br>
<span style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">-- \
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and \
may also be privileged. If you are not the intended recipient, please notify the \
sender immediately  and do not disclose the contents to any other person, use it for \
any purpose, or store or copy the information in any medium. Thank you.<br> <br>
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in \
England &amp; Wales, Company No: 2557590<br> ARM Holdings plc, Registered office 110 \
Fulbourn Road, Cambridge CB1 9NJ, Registered in England &amp; Wales, Company No: \
2548782</span><o:p></o:p></p> </div>
</blockquote>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
</div>
</div>
<br>
<font face="Arial" color="Black" size="2">-- IMPORTANT NOTICE: The contents of this \
email and any attachments are confidential and may also be privileged. If you are not \
the intended recipient, please notify the sender immediately and do not disclose the \
contents  to any other person, use it for any purpose, or store or copy the \
information in any medium. Thank you.<br> <br>
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in \
England &amp; Wales, Company No: 2557590<br> ARM Holdings plc, Registered office 110 \
Fulbourn Road, Cambridge CB1 9NJ, Registered in England &amp; Wales, Company No: \
2548782<br> </font>
</body>
</html>


[Attachment #4 (unknown)]

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic